- last update
about 1 year ago Patch Failed to Apply - Status changed to Needs review
about 1 year ago 8:27am 30 August 2023 - last update
about 1 year ago Build Successful - 🇬🇧United Kingdom catch
Redo of #5 to see if this still happens.
I wonder if this is purely happening when there's only a library or two to load, and the library only contains JavaScript - we don't know whether we need CSS or not until the library definitions have been parsed.
If that's the case, we can skip the sort and optimize, and cache the empty array.
- last update
about 1 year ago 30,098 pass - 🇬🇧United Kingdom catch
And here's what the fix should look like. Not really a bug IMO but saves a bit of work.
- Status changed to RTBC
about 1 year ago 3:03pm 30 August 2023 - 🇳🇱Netherlands Lendude Amsterdam
#24 shows we have all sorts of test coverage hitting this, so no need to add more, change makes sense.
Updated the title to match the fix, we are not returning early because we want the cache to be set.
- last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
about 1 year ago Build Successful - last update
12 months ago Build Successful - last update
12 months ago Build Successful - last update
12 months ago Build Successful - 🇳🇿New Zealand quietone New Zealand
Checking RTBC issues. There are no unanswered questions here or other work to do. I did not review the change itself.
- last update
12 months ago Build Successful - last update
12 months ago Build Successful - last update
12 months ago Build Successful - last update
12 months ago Build Successful - last update
12 months ago Build Successful - last update
12 months ago Build Successful - last update
12 months ago Build Successful 57:23 56:12 Running- last update
11 months ago Build Successful - last update
11 months ago Build Successful - last update
11 months ago Build Successful - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed dc39dd56b6c to 11.x and e8961de11a5 to 10.1.x. Thanks!
-
alexpott →
committed dc39dd56 on 11.x
Issue #2032967 by catch, joelpittet, thedavidmeister, alansaviolobo:...
-
alexpott →
committed dc39dd56 on 11.x
- Status changed to Fixed
11 months ago 8:03am 6 October 2023 -
alexpott →
committed e8961de1 on 10.1.x
Issue #2032967 by catch, joelpittet, thedavidmeister, alansaviolobo:...
-
alexpott →
committed e8961de1 on 10.1.x
- 🇺🇸United States AaronBauman Philadelphia
For future googlers: the symptom that led me to this thread was "Exception: Invalid CSS asset type" error in dblogs.
Exception: Invalid CSS asset type. in Drupal\Core\Asset\CssCollectionRenderer->render() (line 82 of core/lib/Drupal/Core/Asset/CssCollectionRenderer.php).
patch in #25 fixed it.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
10 months ago 6:17am 2 November 2023 - 🇨🇦Canada joelpittet Vancouver
I'm quite sure we should have committed my exception from #5, lol
+ // This is likely an AJAX request, return early. + if (empty($css)) { + throw new \Exception('This should not ever happen, wonder if test produce this helvetica scenario.'); + } +
For the uninitiated https://www.youtube.com/watch?v=-Y-yKmzP-4U