The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.
- Merge request !12223Resolve #2008884 "Provide an interface for TempStore implementations" → (Open) created by AndyF
- 🇬🇧United Kingdom AndyF
Thanks everyone for the work on this.
If we lay hands on this, i'd say let's add interfaces for the factories too.
That's actually what I was looking for. Kinda minor, but on a site with Domain Access I'd like to make the Views UI domain-aware and was hoping to decorate the shared temp store factory, but I can't do that because there's no interface. (No great shakes, I can extend and override, but still...)
I've moved #26 to an MR and added factory interfaces.
- I didn't add type declarations to the new interfaces because of the existing implementations. I don't think these classes are covered by the BC policy, but I didn't want to make life hard for anyone extending them nonetheless;
- I didn't update existing type declarations that reference the concrete temp store implementations, again for abundance-of-caution BC reasons.