Tidy up code following multilingual node properties patch

Created on 26 May 2013, over 11 years ago
Updated 6 August 2023, over 1 year ago

Follow up for #1498674: Refactor node properties to multilingual

Problem/Motivation

Code readability and maintainability - the code requires tidy-up beyond scope of original "refactor node properties to multilingual" issue, and this tidy should not hold up progress on the original issue.

Proposed resolution

Implement tidy-up once #1498674: Refactor node properties to multilingual is completed.

Remaining tasks

  • Clean up code
  • Clean up variable names
  • Code re-flow improvements

User interface changes

None expected.

API changes

None expected.

Original report from 1498674 comment 296

It's great to see that the numbers are finally better with the updated patch. I think the storage code could use some more clean-up, variable name & code-flow improvements etc., but that a) does not need to hold up this great work in any way b) that clean-up will need to go beyond of what this patch introduces - thus deserves its own issue anyway. -> followup.

See http://drupal.org/node/1498674#comment-7457518

📌 Task
Status

Closed: outdated

Version

9.5

Component
Node system 

Last updated 4 days ago

No maintainer
Created by

🇬🇧United Kingdom chrishks

Live updates comments and jobs are added and updated live.
  • D8MI

    (Drupal 8 Multilingual Initiative) is the tag used by the multilingual initiative to mark core issues (and some contributed module issues). For versions other than Drupal 8, use the i18n (Internationalization) tag on issues which involve or affect multilingual / multinational support. That is preferred over Translation.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇳🇿New Zealand quietone

    I do support code cleanup but the Issue Summary is too vague to implement. I read the comment in the other issue and skimmed the patch as well. When the comment was written the patch had 125 files changed, 1160 insertions, 592 deletions. The lack of specifics here for the clean up make that a big task to figure out.

    Given that is 10 years old with no activity, that the code may have changed in that time I am closing this as outdated.

Production build 0.71.5 2024