Modify drupal_rewrite_settings() to allow sticking settings to their comment block

Created on 6 May 2013, about 12 years ago
Updated 3 April 2025, 3 months ago

Follow up for #1921818: Modify drupal_rewrite_settings() to allow writing $settings values β†’

Problem/Motivation

The current implementation of drupal_rewrite_settings() does not allow sticking settings to their comment blocks as proposed in the original issue description.

However, the comment blocks in settings.php are helpful and we want the settings to stick to those blocks.

Proposed resolution

Add more states to drupal_rewrite_settings() when stepping through each token in settings.php trying to replace any variables that are in the passed-in array.

Remaining tasks

Reviews needed.

User interface changes

None.

API changes

None.

Original report by heyrocker

#1921818: Modify drupal_rewrite_settings() to allow writing $settings values β†’

πŸ“Œ Task
Status

Postponed: needs info

Version

11.0 πŸ”₯

Component

system.module

Created by

πŸ‡©πŸ‡ͺGermany derjochenmeyer

Live updates comments and jobs are added and updated live.
  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

  • Status changed to Closed: outdated about 20 hours ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Since there's been no follow up in 3+ months going to close this one out. If still valid task please re-open.

    Thanks

Production build 0.71.5 2024