Incorrect comparison in renderers

Created on 4 March 2013, about 12 years ago
Updated 11 December 2024, 4 months ago

The following is wrong in all renderers:
if (key($settings) == 'quicktabs') {

Because, the key of the settings can be a number as well, and not just a string.
If the key is a number then the comparison will be TRUE. Then the $qtkey variable will have a wrong value.

To fix it, simply the === has to be used.

πŸ› Bug report
Status

Postponed: needs info

Version

3.0

Component

Code

Created by

πŸ‡­πŸ‡ΊHungary nagy.balint

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024