This is a follow up to #1845546: Implement validation for the TypedData API → . I found numerous todos that were related to various approaches with the TypedData Plugin Manager class and it's factory. This patch fixes those todos, removes the expanded and unnecessary usage of createInstance(), move the manager create() method to call $this->createInstance() instead of $this->factory->createInstance(), and appropriately injects the Manager and Validator into the plugins since they apparently need access to them. There are a few documentation thing I did here that I know are patently wrong within the Factory. $name and $parent seem to only mater for non-primitive TypedData plugins, we should document how that matters a bit better. The factory still exists because TypedData plugins have some interesting special casing they need in order to instantiate the proper class (and can apparently be overridden to some degree). I think the changes are probably pretty self explanatory.
Eclipse
Closed: outdated
11.0 🔥
Last updated
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Reviewing the git logs I think this is outdated and the work was accomplished as part of #1867856: Use annotation discovery for data type plugins → . Therefor, I am closing this as outdated.
If that is wrong, re-open the issue and update the issue summary with what still needs to be done.
Thanks