The installer uses an interactive batch for installation. That only works with a working session, which in turn works by setting a cookie. If you are as paranoid as I am :-) or you forgot to exit private mode, you will try to install Drupal but you will end up with a half installed, unrecoverably (until the DB is emptied again) broken, Drupal. That's not very nice.
We already have a built-in step in the installer that checks requirements, so let's add a check that the user has cookies enabled. The only non-trivial part of this is that the test cookie cannot be checked in the same request it is set. I think I've found a fairly (*ducks*) clean way to do this.
Review the attached patch.
Tests
Manual testing
No new UI elements. The string(s) introduced here of course need the usual scrutiny.
None.
Needs work
11.0 🔥
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
I am confused... but isn't this a duplicate of 🐛 Installer does not warn the user that cookies must be enabled with the correct cookie domain (and fails when they aren't) Needs work ?
But at least they definitely overlap so that attempts to fix it should be compared.