System updates are executed without priority

Created on 21 January 2013, almost 12 years ago

Updated 7 February 2023, almost 2 years ago

Problem/Motivation

Under circumstances system updates will not be executed as the first ones even if there are no dependencies preventing this. However there are cases where the system and the DB should be prepared before other updates are allowed to run.

Actually there are a lot of places in the core, which are suggesting that it is desired that system updates are the ones being executed first, but under some circumstances this is not completely guaranteed - e.g. having one system update and multiple updates of another module leads to assigning lower weights to the updates of the other module.

Proposed resolution

In update_build_dependency_graph() find update functions without edges to system updates and add such updates as edges to system updates so that system updates are executed first / get assigned lower weights by \Drupal\Component\Graph\Graph::searchAndSort().

Provide a general check in \Drupal\FunctionalTests\Update\UpdatePathTestBase assuring system updates will be executed first.

Remaining tasks

Review.

User interface changes

None.

API changes

None.

Data model changes

None.

🐛 Bug report

Status

Needs work

Version

10.1 ✨

Component

Database update →

Last updated 3 days ago

No maintainer

Created by

🇨🇦Canada chx

Live updates comments and jobs are added and updated live.

Bug Smash Initiative

Needs issue summary update
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Patch at #85 was never reviewed
Comment almost 2 years ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Tagging for issue summary update, but likely will be 'address feedback in #55'
Status changed to Needs work almost 2 years ago9:53am 7 February 2023
Comment almost 2 years ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024