Fix regressions and further improve tableheader.js

Created on 31 August 2012, over 12 years ago
Updated 30 January 2023, almost 2 years ago

Think this was all introduced in the rewrite: #1574738: Rewrite tableheader.js .

See screenshots:

  1. Original header is visible under sticky header (setting a z-index fixes this, but that might open a whole new can of worms
  2. If for some reason you load the page halfway a table, the sticky table will only show up upon the first scroll. Maybe trigger scroll once on pageload if the table is in the viewport?
  3. There should be a detach behavior to unregister tables that have been removed/replaced.
  4. On scroll/resize handlers should be debounced. The inline docs currently state they are debounced to execute every 250ms, but they are actually executed every possible scroll/resize.
🐛 Bug report
Status

Needs work

Version

10.1

Component
Javascript 

Last updated about 4 hours ago

Created by

🇳🇱Netherlands Kiphaas7

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Production build 0.71.5 2024