Disable comments on change records

Created on 27 June 2012, over 12 years ago
Updated 24 July 2024, 4 months ago

Problem/Motivation

I noticed the change records have comments on by default. I prefer people editing the record than just commenting. I could see a potential explosion of comments when D8 get released with lots of support requests in it.

I see it already with other parts of the documentation. Can we disable those for new change records?

Steps to reproduce

Proposed resolution

Disable adding comments on change records.
Display existing comments as is.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

✨ Feature request
Status

RTBC

Version

3.0

Component

Miscellaneous

Created by

πŸ‡§πŸ‡ͺBelgium aspilicious

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡³πŸ‡ΏNew Zealand quietone

    Adding to parent.

    Yes, let's disable comments on change records. They are simply to record a change that occurred at a given time. I agree that If a change is needed to the change records itself, then someone should just edit it. If the change caused a problem then an issue should be opened in the relevant issue queue so that maintainers and the community know about it. For me, this part is crucial because I would guess that most maintainers monitor their issue queues and not the change records for.

    And for other discussion or information sharing there is Drupal Slack and blog posts.

    In regard to cleaning up existing comments, I don't see the need to do that. I think they can stay as is.

  • πŸ‡ΊπŸ‡ΈUnited States drumm NY, US

    It would be ideal to clean up existing comments after turning them off, so there is one less thing to migrate and otherwise maintain long-term.

  • πŸ‡³πŸ‡ΏNew Zealand quietone

    @drumm, I am not clear on what you mean by 'clean up'? Does that mean delete?

  • πŸ‡ΊπŸ‡ΈUnited States drumm NY, US

    Yes, I should have said delete the comments.

  • πŸ‡³πŸ‡ΏNew Zealand quietone

    @drumm, thanks.
    I think whether to delete or not is a different discussion to disabling them, so I am moving that to another issue. I really want to prevent further comments asap.

    πŸ“Œ Consider deleting comments on change records Active

    • drumm β†’ committed 183178de on 7.x-3.x
      Issue #1663376: Disable comments for new change records
      
  • Assigned to drumm
  • Status changed to RTBC 4 months ago
  • πŸ‡ΊπŸ‡ΈUnited States drumm NY, US

    I'll go ahead and get this moving. Comments are not allowed for new change records. The next step is disabling them for existing change records and πŸ“Œ Consider deleting comments on change records Active

    • drumm β†’ committed 183178de on owner-tools-user-credit-view-followup
      Issue #1663376: Disable comments for new change records
      
Production build 0.71.5 2024