Replace \Drupal\Component\Archiver::getArchive() with __call()

Created on 12 June 2012, almost 13 years ago

Updated 1 April 2025, 4 days ago

We have the following code:

namespace Drupal\Component\Archiver;

use ZipArchive;

/**
 * Defines a archiver implementation for .zip files.
 *
 * @link http://php.net/zip
 */
class Zip implements ArchiverInterface {
// ...
  public function getArchive() {
    return $this->zip;
  }
}

it can violates encapsulation. It can be refactored as follows:

class Zip implements ArchiverInterface {
// ...
  public function __call($method, $args) {
    return call_user_func_array(array($this->zip, $method), $args);
  }
}

📌 Task

Status

Postponed: needs info

Version

11.0 🔥

Component

base system

Created by

🇺🇦Ukraine hinikato

Live updates comments and jobs are added and updated live.

API change
Changes an existing API or subsystem. Not backportable to earlier major versions, unless absolutely required to fix a critical bug.

API clean-up
Refactors an existing API or subsystem for consistency, performance, modularization, flexibility, third-party integration, etc. May imply an API change. Frequently used during the Code Slush phase of the release cycle.

stale-issue-cleanup
To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 4 days ago →
🇺🇸United States smustgrave
Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024