- last update
over 1 year ago 2,153 pass - last update
over 1 year ago 2,153 pass - last update
over 1 year ago 2,153 pass - last update
over 1 year ago 2,153 pass - last update
over 1 year ago run-tests.sh exception - last update
over 1 year ago 2,153 pass - last update
over 1 year ago 2,153 pass - last update
over 1 year ago 2,153 pass - last update
over 1 year ago 2,153 pass - last update
over 1 year ago 2,153 pass - last update
over 1 year ago 2,153 pass - last update
over 1 year ago run-tests.sh exception - last update
over 1 year ago 2,154 pass - last update
over 1 year ago 2,154 pass - last update
over 1 year ago 2,155 pass - last update
over 1 year ago 2,155 pass - last update
over 1 year ago 2,150 pass, 3 fail - last update
over 1 year ago run-tests.sh exception - last update
over 1 year ago run-tests.sh exception - last update
over 1 year ago 2,154 pass, 2 fail The last submitted patch, 21: 1451072-21_test-only.patch, failed testing. View results →
- 🇸🇰Slovakia poker10
If we are OK with the fact, that the orphaned comments are not deleted and actually left in the database (see the comment #1), then I think this seems good.
Just a note - these orphaned comments are not visible in the node detail, nor in the comments list at
admin/content/comment
, so users will have no idea about these data being left in the database. This patch will remove the error, but the actual cause of the problem will not be resolved. On the other hand, it would require a lot bigger effort to allow correctly delete the comments because ofcomment_load_multiple
(which is probably not worth the effort in this phase).Adding a tag for the second maintainer review.
- last update
over 1 year ago 2,154 pass, 2 fail The last submitted patch, 21: 1451072-21_test-only.patch, failed testing. View results →
- last update
over 1 year ago run-tests.sh exception - last update
over 1 year ago 2,154 pass, 2 fail The last submitted patch, 21: 1451072-21_test-only.patch, failed testing. View results →
- last update
over 1 year ago 2,154 pass, 2 fail The last submitted patch, 21: 1451072-21_test-only.patch, failed testing. View results →
- last update
over 1 year ago 2,151 pass - 🇬🇧United Kingdom mcdruid 🇬🇧🇪🇺
I think this looks good.
If anyone was afflicted with an orphaned comments problem because of a particular workflow on their site, they could write a module / drush command to address that. I don't think we need to hold this fix up on trying to solve that problem though.
- last update
over 1 year ago 2,155 pass - Status changed to Fixed
over 1 year ago 4:42pm 26 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.