The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
about 2 years ago 10:19am 5 February 2023 - Status changed to Needs work
about 2 years ago 1:12pm 7 February 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
about 2 years ago 5:10pm 18 February 2023 - Status changed to RTBC
about 2 years ago 8:24am 19 February 2023 - Status changed to Needs work
about 2 years ago 8:25am 19 February 2023 - 🇬🇧United Kingdom jonathanshaw Stroud, UK
My bad, the postgres test failures need addressing.
- Status changed to Needs review
about 2 years ago 9:09am 25 February 2023 - 🇦🇹Austria drunken monkey Vienna, Austria
This should do it.
Escaping of the field names already happens increatePrimaryKeySql()
, so no need to callescapeField()
, too. - Status changed to RTBC
about 2 years ago 11:37am 25 February 2023 - 🇫🇷France andypost
Changes looks good and covered with yesrs, queued tests for pgsql and sqlite
-
larowlan →
committed 5074bef0 on 10.0.x
Issue #1148856 by drunken monkey, stefan.r, bzrudi71, xatoo, Ben Coleman...
-
larowlan →
committed 5074bef0 on 10.0.x
-
larowlan →
committed 032089af on 10.1.x
Issue #1148856 by drunken monkey, stefan.r, bzrudi71, xatoo, Ben Coleman...
-
larowlan →
committed 032089af on 10.1.x
- Status changed to Downport
about 2 years ago 8:16am 31 March 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Committed to 10.1.x and 10.0.x
Doesn't apply to 9.5.x, marking as patch to be ported.
Thanks folks!
-
larowlan →
committed df52d5c8 on 10.0.x
Revert "Issue #1148856 by drunken monkey, stefan.r, bzrudi71, xatoo, Ben...
-
larowlan →
committed df52d5c8 on 10.0.x
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Rolled this back from 10.0.x, ::getPrefix doens't exist there so HEAD was broken
- Status changed to Fixed
about 2 years ago 11:36am 3 April 2023 - 🇬🇧United Kingdom catch
Since we don't have the ::getPrefix method in 10.0.x, I think we should leave this in 10.1.x - makes it not a straight backport.
- 🇮🇹Italy mondrake 🇮🇹
Given the conditional
protected function supportsPrefixLength(): bool { return $this->connection->driver() === 'mysql'; }
the test should have been a
DriverSpecificDatabaseTestBase
extending test, no?Sorry for late feedback
- 🇳🇱Netherlands daffie
@mondrake: I have created the followup for extending DriverSpecificDatabaseTestBase. See: 3351886