breidert → credited federiko_ → .
Same issue for me ; if anyone has an idea...
Patch from #64 applied to 7.0.0-alpha1 seems to be working well for me ; here is the generated link code :
<a class="test-css" href="/fr/mentions-legales" target="_blank" aria-label="test-aria" id="test-idd" rel="test-rel" data-entity-type="node" data-entity-uuid="7a012594-8e2f-446f-8559-ac377b1ec0d5" data-entity-substitution="canonical" tabindex="-1" data-title="Test title">Test link</a>
federiko_ → created an issue.
"Edit the body field, and replace `body` in the URL with the layout field name: `layout_builder__layout`"
I am not sure to understand what is meaned there. Is it possible to have more details ?
The CSS fix is working for me, if I apply it manually into dist/css/styles.css
I don't know if it is helping to validate the MR.
Also I am not sure that this is directly related to this issue, but :
what if someone want to work with SASS ? I see in the src folder that there are a few SASS related files.
For the footer I can see that there is a src/sass/component/Footer/_footer.scss file.
Yes my bad @mfb I published those patches too quickly, I'm sorry! It worked in my dev environnment but when deploying my code to real world (MySQL 8 with sql_generate_invisible_primary_key enabled) above patches (#92 and #93) didn't work.
[error] SQLSTATE[42000]: Syntax error or access violation: 1235 This version of MySQL doesn't yet support 'existing primary key drop without adding a new primary key. In @@sql_generate_invisible_primary_key=ON mode table should have a primary key. Please add a new primary key to be able to drop existing primary key.': ALTER TABLE "honeypot_user" DROP PRIMARY KEY; Array
> (
> )
>
> [error] Update failed: honeypot_update_8102 A cleaner version of the patch in #92
And that is a patch for 2.1.3 stable release
This is a patch for the actual dev version of honeypot module, taking into account the issue mentioned just above, when primary key exists and cannot be deleted
Same issue here (core version 9.5.10 PHP 8.1 MySQL 8)
hook update did not end and we got this MySQL error :
[error] SQLSTATE[HY000]: General error: 4111 Please drop primary key column to be able to drop generated invisible primary key.: ALTER TABLE "honeypot_user" ADD "id" INT NOT NULL auto_increment COMMENT 'Unique record ID.', DROP PRIMARY KEY, ADD PRIMARY KEY ("id");
Same issue here !
My buggy view config :
uuid: 543cbe64-b6ec-4c44-abca-f1548e4a322b
langcode: fr
status: true
dependencies:
config:
- user.role.cf
module:
- user
id: entiref_view_or_filter_bug
label: 'Référents CF'
module: views
description: ''
tag: ''
base_table: users_field_data
base_field: uid
display:
default:
id: default
display_title: Default
display_plugin: default
position: 0
display_options:
fields:
name:
id: name
table: users_field_data
field: name
relationship: none
group_type: group
admin_label: ''
entity_type: user
entity_field: name
plugin_id: field
label: ''
exclude: false
alter:
alter_text: false
make_link: false
absolute: false
word_boundary: false
ellipsis: false
strip_tags: false
trim: false
html: false
element_type: ''
element_class: ''
element_label_type: ''
element_label_class: ''
element_label_colon: true
element_wrapper_type: ''
element_wrapper_class: ''
element_default_classes: true
empty: ''
hide_empty: false
empty_zero: false
hide_alter_empty: true
click_sort_column: value
type: user_name
settings: { }
group_column: value
group_columns: { }
group_rows: true
delta_limit: 0
delta_offset: 0
delta_reversed: false
delta_first_last: false
multi_type: separator
separator: ', '
field_api_classes: false
pager:
type: none
options:
offset: 0
exposed_form:
type: basic
options:
submit_button: Appliquer
reset_button: false
reset_button_label: Réinitialiser
exposed_sorts_label: 'Trier par'
expose_sort_order: true
sort_asc_label: Asc
sort_desc_label: Desc
access:
type: perm
options:
perm: 'access user profiles'
cache:
type: tag
options: { }
empty: { }
sorts:
name:
id: name
table: users_field_data
field: name
relationship: none
group_type: group
admin_label: ''
entity_type: user
entity_field: name
plugin_id: standard
order: ASC
expose:
label: ''
field_identifier: ''
exposed: false
arguments: { }
filters:
status:
id: status
table: users_field_data
field: status
entity_type: user
entity_field: status
plugin_id: boolean
value: '1'
group: 1
expose:
operator: ''
operator_limit_selection: false
operator_list: { }
field_previous_roles_target_id:
id: field_previous_roles_target_id
table: user__field_previous_roles
field: field_previous_roles_target_id
relationship: none
group_type: group
admin_label: ''
plugin_id: string
operator: '='
value: cf
group: 2
exposed: false
expose:
operator_id: ''
label: ''
description: ''
use_operator: false
operator: ''
operator_limit_selection: false
operator_list: { }
identifier: ''
required: false
remember: false
multiple: false
remember_roles:
authenticated: authenticated
placeholder: ''
is_grouped: false
group_info:
label: ''
description: ''
identifier: ''
optional: true
widget: select
multiple: false
remember: false
default_group: All
default_group_multiple: { }
group_items: { }
roles_target_id:
id: roles_target_id
table: user__roles
field: roles_target_id
relationship: none
group_type: group
admin_label: ''
entity_type: user
entity_field: roles
plugin_id: user_roles
operator: or
value:
cf: cf
group: 2
exposed: false
expose:
operator_id: ''
label: ''
description: ''
use_operator: false
operator: ''
operator_limit_selection: false
operator_list: { }
identifier: ''
required: false
remember: false
multiple: false
remember_roles:
authenticated: authenticated
reduce: false
is_grouped: false
group_info:
label: ''
description: ''
identifier: ''
optional: true
widget: select
multiple: false
remember: false
default_group: All
default_group_multiple: { }
group_items: { }
reduce_duplicates: false
filter_groups:
operator: AND
groups:
1: AND
2: OR
style:
type: default
options:
grouping: { }
row_class: ''
default_row_class: true
uses_fields: false
row:
type: fields
options:
default_field_elements: true
inline: { }
separator: ''
hide_empty: false
query:
type: views_query
options:
query_comment: ''
disable_sql_rewrite: false
distinct: false
replica: false
query_tags: { }
relationships: { }
header: { }
footer: { }
display_extenders: { }
cache_metadata:
max-age: -1
contexts:
- 'languages:language_content'
- 'languages:language_interface'
- user.permissions
tags: { }
manager_cf_users:
id: manager_cf_users
display_title: 'Entity Reference for CF users'
display_plugin: entity_reference
position: 1
display_options:
style:
type: entity_reference
options:
search_fields:
name: name
display_description: ''
display_extenders: { }
cache_metadata:
max-age: -1
contexts:
- 'languages:language_content'
- 'languages:language_interface'
- user.permissions
tags: { }
I've tested drupal 9.5x related patch in existing issue and it seems to resolve the issue in a more dynamic/generic way ; thank you @cilefen
Here is a tiny patch
federiko_ → created an issue.
Any news or any similar module suggestion ?
So to sum up :
- it seems that locale_form_redirect_edit_form_alter() is deprecated code, which removal does not have any impact at all.
- as a consequence of disabling bundle support for the redirect entity and to avoid collision with updated/patched redirect edit form id, it seems also that we could remove this deprecated code
Then the remaining question that I see for a generic implementation is : can the modification of the redirect edit form id have an impact outside of the redirect module ? If a custom module (named my_custom_module) implemented my_custom_module_form_redirect_redirect_edit_form_alter() that custom hook would stop working, is that correct ?
Same problem here...
drush ac --html --detail > ~/Desktop/report.html
=> Command "ac" is not defined
drush abp --html --detail >> ~/Desktop/report.html
=> Command "abp" is not defined
drush aa --html --bootstrap --detail --skip=insights > ~/Desktop/report.html
=> The "--html" option does not exist.
I have received an error related to the code added in comment #5, which has not been commited yet if I am not wrong...
The code added disables the bundle support for redirect entity and had as a consequence to change the redirect entity edit form id and also trigger locale_form_redirect_edit_form_alter()... (which mas not triggered before , if I understand well)
Before that, the form alter was never triggered because it was targeting an old form id (redirect_edit_form and not redirect_redirect_edit_form).
But may be I am missing something...
The language field related code seems to be implemented there, at least in Drupal 9.2+ :
https://git.drupalcode.org/project/redirect/-/blob/8.x-1.x/src/Entity/Re...
I have performed a fresh installation and added a text field through the UI on the redirection module.
I decided to remove the 'locale_form_redirect_edit_form_alter()' hook because it seems to not be used at all, at least in recent drupal core versions. But you're right @Berdir it's possible that doing so could affect compatibility with older versions of Drupal 8 or 9. I will investigate this further.
In my case, in a fresh drupal 9.4.10 installtion, removing the locale_form_redirect_edit_form_alter() function is solving the issue I had.
I applied patch from comment #6 but had no luck. When editing a redirection, an error message appeared stating :
Notice : Undefined index: #value dans locale_form_redirect_edit_form_alter() (/app/web/modules/contrib/redirect/redirect.module ligne 261)
Exception: Object of type Drupal\Core\Language\Language cannot be printed. in Drupal\Core\Template\TwigExtension->escapeFilter() (line 454 of /app/web/core/lib/Drupal/Core/Template/TwigExtension.php)
Environnment = drupal 9.4.10 + PHP 7.4
I got it working thanks to https://github.com/mglaman/composer-drupal-lenient