tea.time → created an issue.
I ran into this and found it surprising there isn't more support for tokens or otherwise dynamically generating pieces of the filename, like using values from an argument.
Thanks @maddentim for the approach in #7. In my case, I found I needed to use `hook_views_pre_view()` to alter the display handler 'filename' config value early enough to happen before the file is generated - see `Drupal\views_data_export\Plugin\views\display\DataExport::processBatch()`.
ahh!!! Found this issue because I am very confused by the fact that the `access()` method is apparently not called by path-based displays, and thus if you need an access check to use custom logic (i.e. cannot be accomplished by a built-in route requirement like permission or role) - you have to implement not only `access()` but also `alterRouteDefinition()` to attach a custom access callback to the route, which I would want to be the same exact logic as this `access()` method is already doing...? Oh man. I'm sad this issue was posted 9 years ago.
These patches are both skipping subscribing to the AddressEvents::INITIAL_VALUES event if it isn't defined by the Address module... but without running that event handler that would be attached, isn't that going to break some functionality of Quick Node Clone? It appears to be setting initial values in an address field from the current node. So if the Address module has removed the event, I'd think Quick Node Clone needs to implement that same functionality another way.
I ran into this too and while I know I could preprocess to extract the URL value for the template, I was curious if there was a simple Twig solution as well.
This worked for me to print the URL appropriately for both internal and external links, with the link field formatter set to "Separate link text and URL":
{% set url = content.field_url.0['#url'] ?? '' %}
<a href="{{ url }}">This is my link</a>
For anyone else who ends up here...
There is a Drupal core issue currently open to enable the CKEditor HTML comment plugin: https://www.drupal.org/project/drupal/issues/3342874 ✨ [upstream] Allow inline HTML comments in ckeditor5 Postponed
However it looks like testing so far hasn't been very successful, and the CKEditor team warns that the plugin is "experimental and not yet production-ready" on their doc page - https://ckeditor.com/docs/ckeditor5/latest/features/html/html-comments.html, so the Drupal issue is marked 'postponed'.
+1 for this! We're using the Phone Label → module and this patch allows the validator to apply to instances of the phone label field with no additional code.
In this case, the error message display is a bit awkward because it appears below both the phone number input and the label input, as well as a third time below the parent form element, but that's a different issue. :)
This seems related?
Actually... I've discovered that table.sticky-header { width: auto; } unfortunately doesn't handle the case of the table wider than the page.
The table is inside a wrapper with horizontal scroll (div.gin-table-scroll-wrapper), so if it's too wide, it'll scroll horizontally. However, the sticky header does not horizontally scroll with it, so the column headings don't stay aligned. :(
@berliner oh my gosh THANK YOU - this has been driving me bonkers on views with many columns in a table, and that bit of CSS seems to work for me too.