πŸ‡ΊπŸ‡ΈUnited States @keith.smith

Account created on 12 October 2006, over 17 years ago
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States keith.smith

"autheticated" is a typo.

I like this patch. Descriptions for roles would be handy. I'd note that we have a couple of varying ways of showing examples in core; this one uses the 'Example: "authenticated user"' rather than the 'Example: authenticated user' approach. In another patch, one of these days, we should really conform these example strings to a single standard.

πŸ‡ΊπŸ‡ΈUnited States keith.smith

Not to be overly picky on code comments, but:

+   * Ensure that menu items that without "visible" children are hidden.

An extra "that" or something?

+ *   The path of the menu item to ensure has children.

Something's not quite right there.

I see this is another good use of compact mode, which I wholeheartedly approve. We don't use setting enough.

These are minor, so I'll leave at CNR and you can take care of them during the next substantive re-roll.

Production build 0.69.0 2024