🇳🇱Netherlands @Maico de Jong

Account created on 28 June 2010, over 14 years ago
#

Recent comments

🇳🇱Netherlands Maico de Jong
  • Encountered an error when validation fails on a field without a label property. Fixed by using the getLabel() method.
  • Update test to check for the improved error message contents.
🇳🇱Netherlands Maico de Jong

Had the same "issue" when trying to alter the paragraphs field options in the allowed_values_function callback based on the parent entity. (node)

MR 46 worked great

🇳🇱Netherlands Maico de Jong

@Madhu Kumar M E

Patch should work, tests also passed. Please make sure you are applying the patch correctly: through composer-patches or manually at the tfa module root using the 2.x-dev branch. Looking at your screenshot the patch was not applied to the tfa module directory.

🇳🇱Netherlands Maico de Jong

Somehow i can no longer reproduce this with the webhook enabled, i will close this for now and re-open if needed.

🇳🇱Netherlands Maico de Jong

Module works fine on Drupal 10 with a small change mentioned in #3272447: Update to PSR/log v3

🇳🇱Netherlands Maico de Jong

Rerolled the latest patch against 2.x-dev:

  • Removed support for 'remaining skips' when forced 2FA is selected for now, Makes it a lot easier to implement and communicate.
  • Rewritten the EventSubscriber and functional tests, reused the available TfaLoginContextTrait.
  • Excluded all 2FA and user login/logout/password paths from forced 2FA redirect.

Maybe it's a good idea to move extra functionalities like configurable whitelist or remaining skips integration (needs new messages) to new tickets and focus on the basics first.

Production build 0.71.5 2024