I can confirm that this issue is still relevant on the development version (commit 517b941f77) on Drupal 11.0.6 on Simplytest.me. See screenshot 3473518.withoutpatchapplied.png
Manual Testing of the patch
I then tested the patch in comment #3 on simplytest.me by setting the module version to 2.x-dev, Drupal to 11.0.6 and supplying the patch. In this environment I can confirm that the patch applies cleanly and that when following the steps to reproduce, I no longer see the error. More specifically, when editing an instance of the markup field with this patch the previously saved value of the "Markup" text area is populated. Changing this value and saving, correctly saves the new value. Viewing the "Add Basic Page" form displays the value of the markup field in the form exactly as I expected.
I also manually tested this in my own local development environment (Drupal 10.4.x-dev; PHP 8.3; PostgreSQL 16 backend; gin admin theme) and it works beautifully!
Code Review
1. The changes in the patch address the specific issue reported and only address that issue.
2. The patch applies cleanly on the most recent development version (commit 517b941f77).
3. The code change follows coding standards and is both clean and easy to read.
Based on my manual testing and code review, I believe this patch is ready! Furthermore, since other users have also reported that it applies cleanly in their environments and fixes the issue, I am marking this "Reviewed and tested by the community".
Hopefully it can be merged soon!
> The primary obstacle for this (as I understand it) is that the markup (and CSS selectors) need to be stable. We are currently changing the markup as needed to squash bugs and fix various technical debt issues.
How much is the markup within Olivero still changing at this point? The above was mentioned as the main obstacle 3 years ago and I would love to hear opinions on how much of a concern this still is when it comes to using Olivero as a base theme?
Background:
Like many, I really want to use Olivero as a base theme. I have tried [the script and manual instructions here](https://github.com/mherchel/olivero-subtheme) to setup my own copy of Olivero as recommended by @mherchel but it was quite intense and even after I have it working in the UI as a theme, it is still not functioning from a development standpoint. Specifically, there is no yarn.lock included and running yarn install I get an empty file. When I try to run yarn build:css I get an error because there is no package.json. I'm guessing all of this is due to changes in the structure of the theme when it moved into Drupal core but I have no idea how to go about resolving it.
The above issues plus the complicated code base that is Olivero really makes me want to use it as a base theme rather than copy the entire thing over. My above question is so that I can make an informed decision about the amount of breaking likely to be caused by core changes. Tbh even if it's a lot I'm starting to think it would still be less work to adapt to a changing core than it would be to try to incorporate fixes into a forked version or write/maintain our own theme from scratch.
Great! Thank you as well for finding that other issue!!! And thank you for pointing to that D10 non-production version of the documentation!!!
I had searched for issues relating to api.drupal.org many times over the last month as I was sure it must be posted somewhere but could not find it.
Since the link to add an issue under the comment on api.drupal.org sent me to post under Drupal Core: Documentation I assumed that issues would be there.
It would be really helpful if the new version of api.drupal.org pointed to the API module issue queue!
laceysanderson → created an issue.