🇹🇼Taiwan @gloomcheng

Thanks for your → for initial feedback on the module review. I've addressed the issues you pointed out, and I'm pleased to announce the release of version 1.0.0-rc1.

Regarding the installation issue on Drupal 10, I've updated the dependencies to resolve conflicts and ensure compatibility. Now, the module should install properly on Drupal 10. You can try installing it again using the following command:

composer require 'drupal/sms_every8d:^1.0.0-rc1' --with-all-dependencies

Additionally, I've resolved the coding standards issues.
I appreciate your assistance in reviewing the code. If you have time, I'd be grateful for another review of the updated module.

I would like to apply for maintainer status for the Lightbox Campaigns module for two main reasons. Firstly, this module provides a convenient mechanism for creating announcement messages using lightboxes. Secondly, many projects are still utilizing this module, yet it has not been updated for some time, causing difficulties in maintaining and updating projects that I am involved with.

I have already prepared the module to be Drupal 10 ready. I have updated and tested the codebase to ensure compatibility with the latest Drupal version, addressing any deprecated APIs or other issues that may arise during the transition. This ensures that the module remains relevant and usable for the Drupal community as they migrate to newer versions of the platform.

Thank you for considering my application.

I would like to reopen this application and kindly request advice on security measures.

gloomcheng → created an issue.

patch #2 works on brand new Drupal 10 site, thanks.

Updated: Add tabs support.

At first, the Batch Resize Image module do very simple thing which is call Image::resize method to resize image assets, and I have tried to set breakpoint to confirm the error message happened when $image->resize() runs.

        if ($file->filesize > $threshold_size && ($width > $size_limit || $height > $size_limit)) {
          // Computing the new height and width based on user input.
          if ($width > $height) {
            $width = $size_limit;
            $height = $height * $width / $width;
          }
          else {
            $height = $size_limit;
            $width = $width * $height / $height;
          }

          // Updating the image size as per set threshold.
          $image->resize($width, $height);
          $image->save();

          // Chnaging the image size in the database.
          $file_entity = \Drupal::entityTypeManager()->getStorage('file')->load($file->fid);
          $file_entity->save();
          $result['message'] = '"' . $file->filename . "\" has been transformed.";
          $context['results']['resized'][] = $result;
        }

Ref: BatchResizeImageForm.php L102:L122

And then, I have tried to modify to use $image->scale() and other methods to validate but get same error.
Therefore, I use alternative similar module Image Compression → to confirm and got the same result, it also faced the issue which can not serialized GdImage object.

Finally I decide to switch PHP version to 7.4 and then the module works, so that I guess this issue most related Drupal core.

I just run the resize functional provieded from Batch Image Resize module without any custom code.
I do some modify to confirm that this issue is most related core instead of Batch Image Resize, and can confirm the module can work on PHP 7.4 environment.

gloomcheng → created an issue.