maybe consider my comment once again ?
https://www.drupal.org/project/drupal/issues/2352009#comment-12814040 →
//This means we may need to update access records,
// flush some caches containing the entity or perform other operations we
// cannot possibly know about.
if we go back to this comment, may i suggest to add new method to `Drupal\group\Plugin\Group\Relation\GroupRelationInterface`
which takes care of invoking exactly the kind of hooks required for each entity instead of calling $entity->save() ?
released in beta3
i am refactoring revision save logic, once that done i will fix the phpcs .
current 2.0.x branch is ready for testing .
do you require backporting to 1.0.x ?
current branch 2.0.x has working version, but :
given the eck route for adding content is shared among different entity types, then the method of defining tabs will not work when one entity has translations pack enabled while another entity is not even defined as translatable .
the solution instead of tabs is to add link for entity operations to dedicated add content route which loads the translations pack .
this should be simple solution, but given i have fulltime job then it will need to wait several days maybe until the weekend .
this is working version, but the code still ugly and need fixing
https://git.drupalcode.org/project/translations_pack/-/commit/cb24240f81...
i refactored code to use entity handler, this way i can now continue to write custom handler for eck entities .
https://git.drupalcode.org/project/translations_pack/-/commit/a278a804df...
looks good .
i am also working on support for inline entity form .
it will be done this weekend .
it is just a routing derivative .
you are correct .
i am working on it .
the add new content route is defined in
src/Routing/TranslationsPackRouteSubscriber.php
i need to add support for eck or maybe define a new plugin type .
this module supports all entities .
simply enable content translation for your eck entities under path : admin/config/regional/content-language
and make sure to check "translations pack" like in the screenshot .
https://www.drupal.org/files/project-images/Screenshot%20from%202023-05-... →
new version symfony diverge in use of parameterbag->all(KEY)
It means that with a class like \Gmagick, the code should not include a use \Gmagick; line.
where does that happen in my code ? i still don't understand .
@jayprakash.kushwah thank you for you help .
but i don't think the lines removing the use statements are correct .
can you explain the issue with : Non-namespaced classes/interfaces/traits should not be referenced with use statements
have you tested your patch ? it takes more than version value to make it compatible with 10 .