🇫🇷France @luukyb

Thanks @nx2611, changes look good to me.

luukyb → created an issue.

Looks good. Please remove the DS_Store files from the theme.

Best way to configure it would be locally on your global git config:
"echo .DS_Store >> ~/.gitignore_global"
Then:
"git config --global core.excludesfile ~/.gitignore_global"

I can confirm that the data is being indexed using @dmundra's patch for me. Didn't work with the patch from @drunken monkey, probably due to my local SOLR instance.
@drunken monkey could you give more details on using hl.method=original ? I'm not sure I used it properly because it didn't work on my end. Thanks!

Hi @_renify_,
I would prefer a solution that avoids changing core.
There is some hints on how to proceed on https://www.drupal.org/project/drupal/issues/3166831 🐛 Css aggregation should exclude assets with attributes from preprocessing Postponed: needs info , and https://www.drupal.org/project/drupal/issues/3166831 🐛 Css aggregation should exclude assets with attributes from preprocessing Postponed: needs info . The latest made a good point on the difficulty to aggregate those files.
Can you adjust the solution to use `
` without aggregation and without changing core?
Thanks!

Hi @aastrong, @nx2611,
Looks good. Will merge.
Thanks!

Luukyb → created an issue.

Hi @aastrong,
Can you test his code on your local and adjust the animation from the MR to get the same as design's gif from @kenyoOwen?
Thanks!

New mixins variables are now in place. Thanks !

This is now merged. Thank you @clarkssquared

Hi @clarkssquared,
Your branch needs a rebase, you should be able to do it now.
Thanks,
Luc

This was tested and merged. Thank you @clarkssquared

You can un-assign from your yourself when you need review @kenyoOwen.
This is reviewed and tested. Merged was done by @nx2611.
Thank you @kenyoOwen. Marking as Fixed.

Hi @nx2611,
Should your new module Yoast SEO be enabled? It’s disabled for me, I don't think it will do anything.
Also I don't see any configuration for the meta tags module.
Please check.
Thanks,
Luc

Reviewing your code contribution @nx2611

Created the merge request for the code change. This needs test and review.
Thanks!

Luukyb → created an issue.

Created the merge request for the code change. This needs test and review.
Thanks!

Luukyb → created an issue.

You are correct @aastrong. Sorry for the confusion, this is good to go.

Hi @nx2611,
Some issues with composer after your changes. You added some changes on composer.json but not in composer.lock, so composer.lock is out dated.
Can you update composer.lock to have gin_lb too?
Thanks,
Luc

Changes look good. Merged. Thanks @nx2611 !

Tested patch on #2 on PHP 8.1 and PHP 8.2. Works well.
It also fixed my error after an upgrade to PHP 8 where my HTML page title was empty. After applying this patch the error disappeared from the logs, and the HTML page title showed again.
Would be great to see this committed in the next version soon. Thanks!

I am closing this issue. Acquia, who acquired Widen, would like to guide users to use the Acquia DAM module → . If you are still a user of this module, please contact your Acquia support team.

I am closing this issue. Acquia, who acquired Widen, would like to guide users to use the Acquia DAM module → . If you are still a user of this module, please contact your Acquia support team.

I am closing this issue. Acquia, who acquired Widen, would like to guide users to use the Acquia DAM module → . If you are still a user of this module, please contact your Acquia support team.

Thanks @aastrong. I think Formtips was the last module that we had a dependency that does not have a version ready for D10.

Next step is to try to run again the following composer command and test Provus out of the box using D10 and updated dependencies modules for D10.
composer require drupal/core-recommended:^10 drupal/core-composer-scaffold:^10 drupal/core-project-message:^10 --update-with-all-dependencies

Thanks Clark !

Additional information from Clark, those are the modules as dependency on Provus, that are not yet ready for Drupal 10:
Advanced Link Attributes (ALA)
Config Distro
Entity Embed
Form Tips
Migrate Plus
Search API AZ Glossary