πŸ‡³πŸ‡±Netherlands @rfbrandsma

Account created on 26 November 2009, about 15 years ago
  • Backend Developer at CipixΒ 
#

Recent comments

πŸ‡³πŸ‡±Netherlands rfbrandsma

Hi ugintl.

When I require the module with the specific version from my MR it does install the patches:
composer require "drupal/layoutcomponents:dev-3447638-10.3-compatibility"

You have to add this fork as a repository in you composer.json to make it work.

"layoutcomponents": {
  "type": "vcs",
   "url": "https://git.drupalcode.org/issue/layoutcomponents-3447638.git"
},
πŸ‡³πŸ‡±Netherlands rfbrandsma

Updated the patch versions to be compatible with Drupal 10.3

πŸ‡³πŸ‡±Netherlands rfbrandsma

rfbrandsma β†’ made their first commit to this issue’s fork.

πŸ‡³πŸ‡±Netherlands rfbrandsma

I can confirm the issue phjou addresses.

I would also like to report another issue with the patches so far:
The wrapper id for the add more button no longer is unique. In Drupal core the Html::getUniqueId($id_prefix . '-add-more-wrapper'); is used to create a wrapper_id. The patches are using $wrapper_id = Html::cleanCssIdentifier($id_prefix . '-add-wrapper');.

πŸ‡³πŸ‡±Netherlands rfbrandsma

I can confirm the issue phjou addresses.

I would also like to report another issue with the patches so far:
The wrapper id for the add more button no longer is unique. In Drupal core the Html::getUniqueId($id_prefix . '-add-more-wrapper'); is used to create a wrapper_id. The patches are using $wrapper_id = Html::cleanCssIdentifier($id_prefix . '-add-wrapper');.

Production build 0.71.5 2024