🇬🇧United Kingdom @Leon Kessler

Account created on 11 September 2009, about 15 years ago
#

Recent comments

🇬🇧United Kingdom Leon Kessler

Hi paulrad, thanks for offering to help maintain this module, and apologies for my delayed response.

I’ve just made you a co-maintainer.

🇬🇧United Kingdom Leon Kessler

I have now marked this module as obsolete, and put a message on the module page.

🇬🇧United Kingdom Leon Kessler

Thanks Catch, that's great news!

Can I just confirm whether the functionality is provided by default in Drupal core, as according to this CR it defaults to POST [#3193798]
Maybe it's different in Views, but would ideally like to see a CR for that so I can link to it from the project page.

In regards to uninstalling, I believe yes it's just a simple case of uninstalling the module. There will be left over config, so that will need to be re-exported to be removed. (I don't have an active Drupal site currently, so can't verify this).

🇬🇧United Kingdom Leon Kessler

I don't see why this patch should not be incorporated into the project. Yes most people will be using this module with an external cache/CDN, and probably have the internal page cache module uninstalled.

However, for those that need to use the page_cache module, it's either this patch, or patching Drupal core with https://www.drupal.org/project/drupal/issues/2352009#comment-14064154 (which is the latest patch on that issue at this current time).

I don't believe there is any harm in setting the correct Expires header, but I suppose there could be some unexpected consequences for someones setup (although you could argue if this does cause an issue for someone, it's a symptom of a bug in their infrastructure, rather than with the Drupal instance itself).

Production build 0.71.5 2024