πŸ‡¨πŸ‡¦Canada @sleepingmonk

Vancouver Island πŸ‡¨πŸ‡¦
Account created on 21 March 2006, about 18 years ago
  • Senior Developer / Technical Consultant at Chapter ThreeΒ  …
#

Recent comments

πŸ‡¨πŸ‡¦Canada sleepingmonk Vancouver Island πŸ‡¨πŸ‡¦

The site_id field uses the "machine_name" form element. I presume to ensure proper characters are used.

The "machine_name" element also requires a check for duplicate machine names and this form does not provide a callback for this. What would it check for duplicates?

I think this may be the wrong field type to use for this. If we are only concerned with ensuring proper name format, it's better to check with field validation and provide a helpful error message.

I've attached a patch that changes the field type to "textfield", adds helpful instruction in the field description, and validates to ensure only letters, numbers, hyphens and underscores are used.

If I'm misunderstanding the purpose of using the machine name element here, please let me know.

πŸ‡¨πŸ‡¦Canada sleepingmonk Vancouver Island πŸ‡¨πŸ‡¦
πŸ‡¨πŸ‡¦Canada sleepingmonk Vancouver Island πŸ‡¨πŸ‡¦

Quick patch.

πŸ‡¨πŸ‡¦Canada sleepingmonk Vancouver Island πŸ‡¨πŸ‡¦

sleepingmonk β†’ created an issue.

Production build 0.69.0 2024