πŸ‡¬πŸ‡§United Kingdom @dakala

Swindon
Account created on 18 March 2006, over 18 years ago
#

Recent comments

πŸ‡¬πŸ‡§United Kingdom dakala Swindon

Same setup here - minimal profile, recipe with gin etc. Until this morning, everything was fine. Then I noticed I'd been using the dev version of gin, so I upgraded to the RC. Immediately, my site was broken with the error in this issue. A search for the error brought me here. When I reverted back to the dev version of gin, the error was gone. Perhaps gin is the source of this?

πŸ‡¬πŸ‡§United Kingdom dakala Swindon

Not sure if this is irrelevant but a contrib module is already using PHP attributes for hook discovery - https://www.drupal.org/project/hux β†’

πŸ‡¬πŸ‡§United Kingdom dakala Swindon

@batigolix: No worries. I don't know how to update forks either. Let's go for the easiest option. I'll merge this now, since it's been tested and marked RTBC before. I'll leave the update to the README in your able hands.

πŸ‡¬πŸ‡§United Kingdom dakala Swindon

Grammar: Here "lets" is a verb not the contracted form of "let us" which is "let's"

πŸ‡¬πŸ‡§United Kingdom dakala Swindon

@Mahmoud Barhouma: The patch looks straightforward. Indeed, the getCountry() method is defined in the Ip2CountryLookup class. Thanks.

πŸ‡¬πŸ‡§United Kingdom dakala Swindon

@batigolix Thanks for all your work on issues. Would you be able to help update the README please? Once that's done, we can merge and release a new version. Once again, thanks.

πŸ‡¬πŸ‡§United Kingdom dakala Swindon

This is another issue stuck in the queue for a while now. Sorry and thanks for the good work!

πŸ‡¬πŸ‡§United Kingdom dakala Swindon

@goron thanks for the report. @marjina-constantin and @batigolix: thanks for the good work. Sorry for the delay in merging.

πŸ“Œ | Country | Add a readme
πŸ‡¬πŸ‡§United Kingdom dakala Swindon

Thanks everyone!

πŸ“Œ | Country | Add a readme
πŸ‡¬πŸ‡§United Kingdom dakala Swindon

dakala β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom dakala Swindon

It seems this has to do with Tracer module (a dependency of Webprofiler) which I had just enabled before seeing the error in this issue. I managed to uninstall both Webprofiler and Tracer and the issue disappeared.

πŸ‡¬πŸ‡§United Kingdom dakala Swindon

Yeah, but it's still happening in DI v6.2.7

πŸ‡¬πŸ‡§United Kingdom dakala Swindon

Thanks everyone for your patience.

Production build 0.69.0 2024