Working without issues, branches aligned again !
Merged into 2.0.x and 3.0.x . Thanks everyone for the effort and contribution !
Patch #4 worked for me also.
Should 2.0.x be also compatible?
It does not seem from the info file
https://git.drupalcode.org/project/shs/-/blob/2.0.x/shs.info.yml?ref_typ...
I created a new 3.x branch and cut a release out of it.
3.x removes several dependencies (namely ECK and SHS) which are not required for main funcionality. I added gitlab ci pipelines coverage to confirm it is now installing with D10 and D11.
Can you confirm you can now fully install?
Adding patch
ricardoamaro → credited hernani → .
Namespace seems incorrect, adding a patch.
Attaching patch
Small typo in the patch
Attaching patch
Attaching static patch from current MR.
DId you try with ?
"drupal/sports_league": "2.x-dev",
This broke release 2.0 as the the Group class was not imported to .module.
@ptmkenny does it keep happening with last patch?
Uploading patch with small changes for local testing.
Line doesn't seem to be needed anymore and tests were green without it.
There were similar changes and comments I could find related to similar fixes:
https://www.drupal.org/project/rules/issues/3346842
📌
[10.0] ModuleHandlerInterface::getImplementations() removed from core
Fixed
https://www.drupal.org/project/group/issues/3278740#comment-14838701
🐛
D10 compatibility
Fixed
Added a functional test and reverted some parts to guarantee support with drush11.
The patch is working for us in all automated tests and scenarios in our internal Drupal distro.
The patch is also passing all the module's automated tests for D9 and d10.
It would be great to have another 1.x release with it !
Attaching patch.
hernani → created an issue. See original summary → .
Attaching patch
Rerolling patch for failed tests.
I believe this problem can't be solved for Group 1.x until https://www.drupal.org/project/group/issues/3367539 📌 Initiative for Group 1.x compatibility under Drupal 10 Fixed is solved.
The failures are already due to group tests which need to be fixed first.
I can make the different tests pass while using an adapted version of the patch present in the issue for 10.x
I can confirm it is solving the issue for me.
Fixing the patch.
Attaching patch for composer usage
hernani → created an issue.