🇦🇹Austria @electric.larry

Patch for merge request #3. Adds seat availability validation for bookings. If the requested number of seats exceeds availability for the selected date and time slot, an error is displayed, preventing the booking.

@mattbloomfield, I think we can mark this one fixed together with # 3498246 🐛 Broken menu visualization for anonymous user since drupal 10.4 Active .

Updated to 7.1.1 and AT Tool 3.x. Works well on 3 different sites.

Imho we can mark this one fixed, @mattbloomfield.

@sd123, it seems to me, you're running in some other problem connected with your setup.

But be careful, use the patch from #14 🐛 Broken menu visualization for anonymous user since drupal 10.4 Active instead of #11. I had to fix a problem with #11.

Also note that not all users could fix their sites with the patch.

I'm sorry but it's hard to remotely debug that problem and I don't have time to get into this further. We'll have to wait for the module maintainer to look at the problem.

But as a temporary workaround what @ilcalle78 suggested seems good to me. Make sure that the unminified javascript files are used and that your caches are properly cleared. drush cr alone will not always pick up changes to the .yml files. Also run "drush cc css-js" or restart webserver to definitly clear all cached stuff.

What the patch does is making the theme name available in the Drupal settings object: settings.at_current_theme_name.

To manually debug and workaround your problem, set a breakpoint where the undefined reading 'theme' error happens and make sure that the call to settings['ajaxPageState']['theme'] is properly repalced with settings.at_current_theme_name. If you can still see the call to settings['ajaxPageState']['theme'], find out how to replace it.

Hope this helps a little.

Thank you @scott_euser and @dravenk for your great examples!

I landed here looking for a way to implement natural sorting of a text field in a view.

My workaround was to use LPAD on the text field and then sort by this field.

/**
 * @file
 * Custom module to implement natural sort order for staff order views.
 */

use Drupal\views\ViewExecutable;
use Drupal\views\Plugin\views\query\QueryPluginBase;
use Drupal\views\Plugin\views\query\Sql;
/**
 * Implements hook_views_query_alter().
 *
 * Alters the query for the "personalbestellungen" view to sort by
 * the custom sort field.
 *
 * @param \Drupal\views\ViewExecutable $view
 *   The view executable object.
 * @param \Drupal\views\Plugin\views\query\Sql $query
 *   The query object for the view.
 */
function wet_personalbestellung_views_query_alter(ViewExecutable $view, Sql $query) {
  if ($view->id() == "personalbestellungen" && $view->current_display === 'page_2') {
    // Add the custom sorting field to the view's query.
    array_unshift($query->orderby, [
      'field' => 'custom_sort_order',
      'direction' => 'DESC',
    ]);
  }
}

/**
 * Implements hook_views_pre_execute().
 *
 * Adds a custom expression for sorting in the "personalbestellungen" view.
 *
 * @param \Drupal\views\ViewExecutable $view
 *   The view executable object.
 */
function wet_personalbestellung_views_pre_execute(ViewExecutable $view) {
  if ($view->id() == "personalbestellungen" && $view->current_display === 'page_2') {
    // Prepend zeros to the order_number, to mimic natural sorting.
    $view->build_info['query']->addExpression("LPAD(order_number, 100, '0')",'custom_sort_order');
  }
}

There was a problem in the previous approach.

I had to move $variables['#attached']['drupalSettings']['at_current_theme_name'] = $active_theme_name; to the at_core_preprocess_page() function to make it work on another test site.

@sd123 could you please try again with the new patch from #14?

Can you please check if the patch in #10 in issue #3498246 fixes the problem?

https://www.drupal.org/project/adaptivetheme/issues/3498246#comment-1595... 🐛 Broken menu visualization for anonymous user since drupal 10.4 Active

Can you please check if the patch in #10 in issue #3498246 fixes the problem?

https://www.drupal.org/project/adaptivetheme/issues/3498246#comment-1595... 🐛 Broken menu visualization for anonymous user since drupal 10.4 Active

Is the patch applied successfully? Did you rebuild the cache?
Could you please check your browser console and post the error message(s) that you can see there?

Here's the patch for 1.1.x.
You should also apply patch from 3501857. It fixes element validation and error handling.

electric.larry → created an issue.

Looking into this now.

Here's the patch that should fix the validation for a required Webform Booking field.

electric.larry → created an issue.

The patch in #9 also fixes another issue with creation of tokens if multiple Webform Booking fields are placed on a form and one of them is submitted empty.

This patch adds the requested cancellation feature.

A new token is available [webform_submission:booking:element_key:cancel_link] that can be placed on the confirmation page or popup. Replace element_key with the machine name of the Webform Booking field. In this example my form has two Webform Booking fields named appointment_booking and appointment_2.

Confirmation page source

Confirmation page display

If you have more than one Webform Booking fields on your form, only place one cancel link on the cofirmation page. Opening the link displays a list of all Webform Booking fields in that submission and allows the user to select the bookings he wants to cancel.

electric.larry → created an issue.

electric.larry → created an issue.

I posted a patch for a workaround here that works with 7.0.x as well as 8.x-5.x:
https://www.drupal.org/project/adaptivetheme/issues/3498246 🐛 Broken menu visualization for anonymous user since drupal 10.4 Active

Please review.

Here's a patch that fixes issue #3498246 as described in #9. Seems to work with 7.* as well as 8.x-5.*
Unsure if this is the most elegant solution, but at least it fixes our broken sites for now :)

Apply the patch

• Go to your site's themes/contrib/adaptivetheme/ directory
• Run patch -p1 < /path/to/the/patchfile.patch

Problem

The problem here is, that the broken JavaScript functions try to read the current theme name from settings['ajaxPageState']['theme']. When your users are logged in they can probably see the toolbar or some other component, that makes sure, that ajaxPageState is not empty. But when you're logged out, settings['ajaxPageState']['theme'] is empty, which leads to the issue.

To better understand the problem, look at at.flexsliderSettings.js for example, at around line 8:

Drupal.behaviors.atFS = {
    attach: function (context, settings) {

      var activeTheme = settings['ajaxPageState']['theme'],
          slideshowSettings = settings[activeTheme]['at_slideshows'];

If you replace 'settings['ajaxPageState']['theme']' with your active theme's name, the issue is resolved.

Also those scripts seem to have the same problem:

• at.breakpoints.min.js
• at.responsiveMenus.min.js
• at.flexsliderSettings.min.js

Proposed resolution

As a temporary workaround I updated functionat_core_preprocess(&$variables) in adaptivetheme/at_core/includes/preprocess.inc at around line 30. Here I store the theme's name in the drupalSettings object.

$variables['page']['#attached']['drupalSettings']['at_current_theme_name'] = $theme['name'];

In all involved JavaScript files I replace settings['ajaxPageState']['theme'] with my new variable that holds the theme name.

My updated preprocess.inc looks something like that:

/**
 * Preprocess variables for all templates.
 *
 * @param $variables
 */
function at_core_preprocess(&$variables) {
  // Add theme variables. template_preprocess is hit many times so we statically
  // cache $theme.
  $theme = &drupal_static(__FUNCTION__);
  if (!isset($theme)) {
    $data = new ThemeConfig(\Drupal::theme()->getActiveTheme()->getName());
    $theme = $data->getConfig();
  }
  $variables['theme'] = $theme;

  // Add current theme name to drupalSettings.
  $variables['page']['#attached']['drupalSettings']['at_current_theme_name'] = $theme['name'];

  // Set global is_front.
  try {

In the involved JavaScript files I replace settings['ajaxPageState']['theme'] with my custom variable settings.at_current_theme_name.
The updated at.flexsliderSettings.js looks like this:

(function ($, Drupal) {

  "use strict";

  Drupal.behaviors.atFS = {
    attach: function (context, settings) {

      var activeTheme = settings.at_current_theme_name;
      var slideshowSettings = settings[activeTheme]['at_slideshows'];

      for (var item in slideshowSettings) {

Here's a patch that should fix issue #3499252.

electric.larry → created an issue.

Now, as we introduced tokens in webform_booking 1.1.4 and submission objects can already create hashes (?token=****) that allow for viewing/updating/deleting submissions, we basically have all we need for the cancellation feature.

@rfmarcelino: In #4, you said: "Currently, the cancellation is deleting the field content.
Is there some cancellation feature in webform_booking already, or are you referring to the built-in functions for editing/updating submissions (webform_submission:token-delete-url, webform_submission:token-update-url)?

Also, in #4, you said: "In terms of auditing, it's not great. It would be probably better to have a hidden 'Canceled' status."
I'm wondering how you'd prefer approaching this. In webform_submission_data, we're saving a value like "2025-01-07 09:00|1" for one booked slot on the 7th. Would you rather just update the value to "2025-01-07 09:00|0" when a user clicks the cancel link, or do you think it would be better to change the value to something like "2025-01-07 09:00|1|cancelled"? Or did you have something completely different in mind for the hidden canceled status?

Tested on 1.1.x. Works as described in the issue description. Instead of adding the class "booked" as suggested by @jbfelix it adds the more descriptive class name "no-slots".

Here's a patch, adding the features from webform_booking-3427876-submission-datetime-formattable.

This adds placeholder variables (tokens) for dynamically personalizing confirmation pages and email notifications.

Available tokens:

[webform_submission:booking:?]
To output individual elements, replace the '?' with the booking form element's key.

[webform_submission:booking:element_key]
Default value. Displays the raw booking date and time ('Y-m-d H:i').

[webform_submission:booking:element_key:date]
Displays the booking date formatted using the default html_date format ('Y-m-d').

[webform_submission:booking:element_key:date:*]
Replace the '*' with the machine name of a custom format defined in Date and Time Formats (/admin/config/regional/date-time) to display the booking date in a specific format. E. g. [webform_submission:booking:element_key:date:long]

[webform_submission:booking:element_key:time]
Displays the booking time formatted as 'H:i'.

[webform_submission:booking:element_key:slots]
Displays the number of slots booked.

For a client's application form, I needed to display the selected time slot in a user-friendly date and time format. By default, using the webform_booking token on the confirmation page or in emails shows a raw value like 2024-12-31 13:37|1. However, the client wanted a format like Montag, 17. Februar 2025 - 09:20 Uhr.

To achieve this, I used hook_tokens_alter() to extract and format the date and time from the webform_booking field, replacing the token with the formatted value.

In this example, the webform_booking field key is terminreservierung. I placed the token [webform_submission:values:terminreservierung] on the confirmation page and in confirmation emails.

function mymodule_tokens_alter(array &$replacements, array $context, BubbleableMetadata $bubbleable_metadata) {
  if (isset($context['type'], $context['data']['webform_submission']) &&
    $context['type'] === 'webform_submission') {

    // Replace reservation field token with formatted date.
    if (!empty($context['tokens']['values:terminreservierung'])) {
      $submission = $context['data']['webform_submission'];
      $appointment = $submission->getElementData('terminreservierung');
      // Extract Date and time from submission info.
      // Submission field holds date, time and number of slots. "2025-02-17 09:20|1".
      $slot_data = explode('|', $appointment);
      $slot_start_time = new \DateTime($slot_data[0]);
      // Format date using the "long" date format.
      $value = \Drupal::service('date.formatter')->format(
        $slot_start_time->getTimestamp(),
        'long'
      );
      $replacements[$context['tokens']['values:terminreservierung']] = $value;
    }
  }
}