RamaiyaA → created an issue.
Thank let me know if you find any other issue regarding the media popup
Thanks prem for requesting a merge request for phpcs issue
plz let me know if any other issue you got
RamaiyaA → changed the visibility of the branch 3423176-readme-file-update to hidden.
Please check and fix all phpcs first
FILE: /var/www/html/testing/web/modules/custom/calendar_event_notifications/css/calendar_event_notifications.css
----------------------------------------------------------------------------------------------------------------
FOUND 31 ERRORS AFFECTING 26 LINES
----------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
8 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
13 | ERROR | [x] CSS colours must be defined in lowercase; expected #04aa6d but found #04AA6D
28 | ERROR | [x] CSS colours must be defined in lowercase; expected #04aa6d but found #04AA6D
29 | ERROR | [x] Blank lines are not allowed in class definitions
40 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
40 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
43 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
45 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
45 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
49 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
50 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
53 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
53 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
55 | ERROR | [ ] Style definitions must end with a semicolon
56 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
57 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
57 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
64 | ERROR | [x] Expected 1 newline at end of file; 0 found
64 | ERROR | [x] Additional whitespace found at end of file
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 30 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/testing/web/modules/custom/calendar_event_notifications/js/calendar_event_notifications.js
--------------------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 12 LINES
--------------------------------------------------------------------------------------------------------------
4 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
5 | ERROR | [x] Whitespace found at end of line
18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
19 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
20 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
21 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
31 | ERROR | [x] Whitespace found at end of line
34 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
97 | ERROR | [x] Whitespace found at end of line
98 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
114 | ERROR | [x] Expected 1 newline at end of file; 3 found
116 | ERROR | [x] Additional whitespace found at end of file
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------
Time: 255ms; Memory: 12MB
I fixed phpcs issues and remove deprecated function file_create_url() on src/Services/MediaPopupFileUrlGenerator.php
RamaiyaA → created an issue.