🇪🇸Spain @einarulfhednar

Hi, I have created a fork to fix the bug.

Waiting for the module maintainer to review and accept it.

Regards.

einarulfhednar → made their first commit to this issue’s fork.

einarulfhednar → created an issue.

einarulfhednar → made their first commit to this issue’s fork.

einarulfhednar → made their first commit to this issue’s fork.

einarulfhednar → created an issue.

einarulfhednar → created an issue.

einarulfhednar → changed the visibility of the branch 3372066-custom-breadcrumb-text to active.

einarulfhednar → changed the visibility of the branch 3372066-custom-breadcrumb-text to hidden.

einarulfhednar → created an issue.

add the patch

einarulfhednar → created an issue.

Fixed and close.

Fixed and close.

Hello to all,

First of all, thank you for the solution.

I tried to apply the patch for version 2.2.12 of the module on the portal I'm working on (Drupal version 9.5.9 and PHP version 8.0.30) and it failed, so I have generated the patch.

Regards.

einarulfhednar → created an issue.

Problem/Motivation

When we have the scheduled newsletter enabled and we want to disable it by unchecking the 'Enable scheduled newsletter' option, visually the option remains checked and in the 'simplenews_scheduler' table of the database the status of the 'activated' column never changes to 0.

This is because, when the data is collected from the database (line 39 of the simplenws_scheduler.module file) a condition is not set to select those rows that have the status of the 'activated' column to 1 and, therefore, it never goes through the else on line 50 of the same file.

Steps to reproduce

1. Check Activate scheduled newsletter option.
2. Click Save scheduler settings button.
3. Uncheck Activate scheduled newsletter option.
4. Click Save scheduler settings button.

Proposed resolution

In the data fetching (line 39 of the simplenews_scheduler.module file) add the condition to select the rows of the 'activated' column to 1.

With this we get that, if there are no elements, it passes by else of the condition of line 46 and the variable $checked is set to FALSE.

einarulfhednar → created an issue.

Hi, I'm using Drupal version 9.5.8 and #5 works.

Thank you very much.

Hello again,

Sorry for the duplicity of comments: I am new and this is my first time.

I attach the correct file.

Thank you.

Hello,

I re-rolled the #51 patch for the 9.5.7 Drupal core.

Thanks, I hope it helps.