Account created on 28 July 2022, almost 2 years ago
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States andystitt829

The patch applies for me. The only feedback I have is that the anchor element that the skip link is targeting within the tags:

<a href="#main-content" id="main-content" tabindex="-1" title="Main Content"></a>

doesn't need the href attribute in it since that's already contained in the skip link that links to it at the top of the page. It can just be:

<a id="main-content" tabindex="-1" title="Main Content"></a>

πŸ‡ΊπŸ‡ΈUnited States andystitt829

I tested the provided patch, and it works.

Before the patch:

After the patch:

I think it's a good idea to not have the language switcher block have the navigation role attached to it as a default. Depending on how it's implemented, it could be a navigation menu on its own, or it could not.

For example, I inserted it in the header and kept the block title. This made it a navigation menu on its own.

However, if someone inserted it into the navigation menu, didn't keep the block title, and styled it to look like other items in the navigation menu, then it would be part of the larger navigation menu and not one on its own.

Production build 0.69.0 2024