Very good observation, if it is possible to fix it in the dev branch (9.1.x)
ricardoamaro → credited nesta_ → .
I would like to express my sincere appreciation for addressing the issue titled "Checkboxes are not aligned with the text" in our Drupal theme. Your dedication to resolving this problem is highly valued.
I would like to take this opportunity to provide a detailed description and explanation of how to address this issue more efficiently, aligning with development best practices and keeping our code cleaner and more organized.
Issue Description:
The current issue refers to an alignment problem with checkboxes in our Drupal theme. To address this issue, patches have been provided that directly modify the compiled CSS. While these patches may temporarily resolve the issue, it is essential to highlight that they do not follow best development practices and may lead to long-term maintenance issues.
Explanation of the Suggested Solution:
To address this issue more efficiently and sustainably, it is recommended to follow these steps:
1.- Documentation:
Before making any changes to the code, ensure you consult the documentation for our Drupal theme. This will provide you with a deeper understanding of the theme's structure and style conventions.
2.- Modify the Corresponding Sass Partial:
Identify the Sass partial that controls the styles of the checkboxes in question. Make sure this is the correct location for making style modifications.
3.- Run the Gulp Task:
Once you have made the necessary modifications to the Sass partial, execute the corresponding Gulp task to compile the CSS. This will ensure that the changes are reflected in the compiled CSS.
4.- Submit the .sass Patch:
Instead of directly modifying the compiled CSS, submit the patch containing the modifications to the Sass file (.sass). This will allow for a more transparent review and smoother integration of the changes into the codebase.
Conclusion:
I appreciate your commitment to resolving this issue and your attention to this detailed explanation of the suggested solution. By following these steps, we can keep our code more organized and adhere to development best practices, making future updates and maintenance of the Drupal theme more manageable.
I hope this information is helpful, and we can work together to effectively and efficiently resolve this issue. If you have any further questions or need additional guidance, please do not hesitate to contact me.
Sincerely,
Nesta
Thank You for Reporting the Issue
Dear Shweta Sharma,
I wanted to extend my heartfelt appreciation to you for bringing the issue to our attention. Your feedback is invaluable in helping us improve our contributed theme.
We have acknowledged the problem you mentioned regarding the misalignment of checkboxes with the text, causing layout issues. Rest assured, our development team is actively looking into this matter. We are committed to addressing this issue promptly and will be working on a patch to resolve it.
Your diligence in reporting this problem is a testament to our collaborative community, and your contribution plays a vital role in enhancing the overall quality of our theme. We will keep you updated on our progress, and please feel free to reach out if you have any further insights or questions.
Once again, thank you for your valuable input. We greatly appreciate your support in making our theme even better.
Warm regards.
add Tag DrupalCampES
Rerolled #86 against 8.1.x
Retest to 8.1.x-dev
Rerolled the latest patch. Hope it works.