Re-roll of patch of #18 for 10.2.6 attached.
Ugh, redone, undoing the changes to use $this->entityTypeManager(). One can hardly use that in `static` methods.
Uploaded a variant of my patch 16, re-rolled to include upstream changes, and that uses $this->entityTypeManager(). I didn't try to use dependency injection, as it seems that would require bigger changes.
I've been using the patches at #102, which for me solve the immediate issue. However, I just noticed that they seem to break something else: after installing the patch, install.php no longer shows the nice "Drupal already installed" page but a page showing exceptions with a stacktrace.
To reproduce:
Install rules without this patch.
Go to .../core/install.php. Observe the "Drupal already installed" page.
Install patch #102. Reload .../core/install.php.
I see a page with this content:
Additional uncaught exception thrown while handling exception.
Original
Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "state". in Symfony\Component\DependencyInjection\ContainerBuilder->getDefinition() (line 1030 of /...path-omitted.../dev/vendor/symfony/dependency-injection/ContainerBuilder.php).
Symfony\Component\DependencyInjection\ContainerBuilder->getDefinition('state') (Line: 600)
Symfony\Component\DependencyInjection\ContainerBuilder->doGet('state', 1) (Line: 558)
Symfony\Component\DependencyInjection\ContainerBuilder->get('state') (Line: 488)
Drupal::state() (Line: 89)
Drupal\rules\EventSubscriber\GenericEventSubscriber::getSubscribedEvents() (Line: 37)
Drupal\Core\DependencyInjection\Compiler\RegisterEventSubscribersPass->process(Object) (Line: 94)
Symfony\Component\DependencyInjection\Compiler\Compiler->compile(Object) (Line: 762)
Symfony\Component\DependencyInjection\ContainerBuilder->compile() (Line: 1344)
Drupal\Core\DrupalKernel->compileContainer() (Line: 948)
Drupal\Core\DrupalKernel->initializeContainer() (Line: 20)
Drupal\Core\Installer\InstallerKernel->initializeContainer() (Line: 487)
Drupal\Core\DrupalKernel->boot() (Line: 426)
install_begin_request(Object, Array) (Line: 116)
install_drupal(Object) (Line: 48)
Additional
Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "theme.manager". in Symfony\Component\DependencyInjection\ContainerBuilder->getDefinition() (line 1030 of /...path-omitted.../dev/vendor/symfony/dependency-injection/ContainerBuilder.php).
Symfony\Component\DependencyInjection\ContainerBuilder->getDefinition('theme.manager') (Line: 600)
Symfony\Component\DependencyInjection\ContainerBuilder->doGet('theme.manager', 1) (Line: 558)
Symfony\Component\DependencyInjection\ContainerBuilder->get('theme.manager') (Line: 659)
Drupal::theme() (Line: 22)
_drupal_maintenance_theme() (Line: 506)
drupal_maintenance_theme() (Line: 1025)
install_display_output(Array, Array) (Line: 271)
_drupal_log_error(Array, 1) (Line: 365)
_drupal_exception_handler(Object)
Undo the patches. Reload .../core/install.php. You get the "Drupal already installed" page again.
Please also see if it makes sense to do something with #3313995: Support adding additional dependencies → at the same time.
... let's officially reduce the scope to the deprecated (and in 10.x, removed) library dependency.
Yes, that's exactly what I meant by:
Only the last reported issue seems to be relevant here ...
Thank you for fixing.
Explanation and examples showing how to use core/once instead of jquery.once in the behavior definition:
https://www.drupal.org/docs/drupal-apis/javascript-api/javascript-api-overview →