Account created on 29 September 2020, about 4 years ago
#

Merge Requests

Recent comments

πŸ‡ΈπŸ‡ͺSweden erikbrgn

@dalin, I took your feedback to my colleagues and this is what we came up as a solution for now:

Fullscreen:

Tablet (aligned left to make it stand out somewhat):

Mobile (labels hidden to save space)

πŸ‡ΈπŸ‡ͺSweden erikbrgn

@dalin, unfortunately no overlap. I went with my companies UX-designers design, but it was mostly as a band-aid in order for us to start using this theme.

πŸ‡ΈπŸ‡ͺSweden erikbrgn

I've looked into this for a bit and this is what I've found:

Claro is a part of core and uses PostCSS for styling. There's a `dropbutton.pcss.css` in Claro which adds the CSS-variables you're talking of, but in the final CSS `dropbutton.css` the variables are missing. There is just an empty `:root` tag with the same comments as in the PostCSS file, but the variables are missing. I'm guessing that this is a PostCSS issue in core, rather than an issue with Gin. However, relying on variables provided by someone else isn't great and can lead to a lot of issues.

πŸ‡ΈπŸ‡ͺSweden erikbrgn

Yeah, this is not optimal from UX PoV.

I'll make an attempt at changing this behavior/design.

πŸ‡ΈπŸ‡ͺSweden erikbrgn

Providing a patch which will work for 2.0.0-alpha1 assuming the module is installed using source.

πŸ‡ΈπŸ‡ͺSweden erikbrgn

Trying a reroll of your patch, Alex, against the latest dev.

πŸ‡ΈπŸ‡ͺSweden erikbrgn

Can we get the ball rolling on this perhaps?

πŸ‡ΈπŸ‡ͺSweden erikbrgn

I'll get the ball rolling on this issue once again.

@smustgrave, just like you pointed out, it was a pretty miserable experience trying to go from 9.2.x to 10.1.x. So, I've started on a new (feature) branch with 10.1.x as base. I'll make an attempt to fix things based on larowlan's feedback.

Production build 0.71.5 2024