@marioki

I suggest merging the MR in 📌 Drupal 10 update Needs review as it incorporates this issues' changes as well as the D10 compatibility changes from 📌 Drupal 10 update Needs review .

I suggest merging the MR in https://www.drupal.org/project/dc_ajax_add_cart/issues/3332554 📌 Drupal 10 update Needs review as it incorporates this issues' changes as well as the trusted callback from https://www.drupal.org/project/dc_ajax_add_cart/issues/3208694 🐛 D9: UntrustedCallbackException Needs work .

Thanks @Arantxio. Tested on our site as well and everything is working fine. @gaurav.kapoor and other maintainers, please consider merging this and releasing a Drupal 10 release.

Old patch does not apply anymore, new one is attached

This is an issue on some sites due to a missing dependency in libraries.yml.

With the new commerce update this is also not enough. In AjaxAddToCartForm.php __construct can be removed and the static create function needs to look similar to the new AddToCartForm.php create function i.e. calling the parent create function and assigning the refreshPageElementsHelper afterwards.

@AdamPS

The Sender should come from site configuration. If you want to change it, set "site mail" in the Basic site settings - that's exactly what that setting is for, clearly documented in the description. So why is another setting needed?

There are use cases outside of this, e.g. you can have more than one commerce store with different email addresses. This is a core commerce feature, see commerce_store_mail_alter

function commerce_store_mail_alter(&$message) {
  if (substr($message['id'], 0, 9) == 'commerce_' && empty($message['params']['from'])) {
    /** @var \Drupal\commerce_store\CurrentStoreInterface $current_store */
    $current_store = \Drupal::service('commerce_store.current_store');
    $current_store = $current_store->getStore();
    if ($current_store) {
      $message['from'] = $current_store->getEmailFromHeader();
    }
  }
}

I second the need for this feature, because it greatly improves performance if grouping is done by the database. Patch #2 works well, is there any reason not to include this in the module, at least as a configurable option so existing views do not break?

marioki → created an issue.

marioki → created an issue.

Added use-ajax-submit class to ensure that if the same wishlist form is displayed more than once on the same page, it still uses ajax for submission.