πŸ‡©πŸ‡ͺGermany @Kevin Hoffmann

Berlin
Account created on 10 December 2019, almost 5 years ago
#

Merge Requests

Recent comments

πŸ‡©πŸ‡ͺGermany Kevin Hoffmann Berlin

I added a fork for version 2.x that sets the access checks to false like @hchonov suggested. This fixes an issue with node related update events - especially unpublished ones.

The problem is that we fetch all nodes with update flags first before deciding who should run the update. Setting the access check during the retrieval to TRUE means cron and drush runs will not be able to see unpublished nodes and therefore miss those completely. An alternative would be to switch to user 1 during query execution but might as well just ignore the access check then for the same result. We cannot switch to a specific user yet during that query as we dont even know if and how many updates there are and which nodes are affected.

Each specific update will then later be executed as the user specified in the modules configuration.

πŸ‡©πŸ‡ͺGermany Kevin Hoffmann Berlin

Kevin Hoffmann β†’ changed the visibility of the branch 3228974-query-for-retrieving to active.

πŸ‡©πŸ‡ͺGermany Kevin Hoffmann Berlin

Kevin Hoffmann β†’ changed the visibility of the branch 3228974-query-for-retrieving to hidden.

πŸ‡©πŸ‡ͺGermany Kevin Hoffmann Berlin

+1 for the patch

Also as a side note facetsRemoveQueryParams() contains

This only applies when the method is POST.

in its docstring. That being said its not even checking that condition itself and applies also for GET requests on my side. Aside from the fact that we remove keys from $request->query which afaik is related to GET requests to begin with.

πŸ‡©πŸ‡ͺGermany Kevin Hoffmann Berlin

patch works for me - issue is still ongoing with v1.1.1

Production build 0.71.5 2024