While it is really awesome that this was improved/fixed, I no longer use this module or the website that had it so I will not be able to test it out sadly...
After having a friend review the thread for me,
the minification stuff that was talked about (from #10 to #16) was only a secondary thing that was mentioned in regards to full fixing the site which did not have anything to do with the actual main issue from #1. You are correct that "that" part should have been a separate issue, but since it wasnt related to ECA at all, and the issue in #1 had not occurred again, I just kept "writing". I apologize.
I thought the original issue was solved in #10. however the original issue started occurring again, which I mentioned in #17.
I am wondering if its because I am native french or being really unclear with my explanations...
but there has only ever been a SINGLE issue I have tried to fix... ever...
(sure we talked about how to setup the log files but that was never an actual "issue")
I could copy paste the top #1 post of this, along with the 2 attachments, and the log... because honestly thats all you need.
If you want me to restart in another one, I guess I can copy paste all of that in a new one, but since it is 100% the same thing since the very start, I don't understand why.
That is probably because I did it "twice"... the "end part" where the condition was false should probably be ignored (i just went back into the node and changed 1 value after) - so the 2nd time obviously the condition returned false as it should have.
The first time (when it did return true) however, the issue was that the "site variable" did not increase by 1.
This is 100% the same "issue" I was reporting at the top here.
Looking at the image I shared originally :
https://www.drupal.org/files/issues/2023-03-30/visual-representation-eca... →
The Site settings did not increment, the ID was saved, but with the old non-incremented value.
So in that case its the "tamper math" that did not process properly for whatever reason.
I actually JUST updated a node from "playing" to "completed" and the bug occurred! the site integer value did not increase!
I actually went back in the node afterwards and updated one other value and saved it again so this "double" save might show up, but only one of them should trigger ECA when i change from "playing" to "completed"
Here is the full "log" for today :
HawkX 21:18:47 Lazy appliance check for event eca.content_entity.presave regarding ECA ID process_hv3nnbu resulted to apply.
- user (Entity user/19/HawkX)
HawkX 21:18:47 Loading ECA configurations for event eca.content_entity.presave: process_hv3nnbu.
- user (Entity user/19/HawkX)
HawkX 21:18:47 Check On Saving (Event_0v54u0o) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
- user (Entity user/19/HawkX)
HawkX 21:18:47 Start On Saving (Event_0v54u0o) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
HawkX 21:18:47 Check action successor AND (Activity_045dq0r) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
- entity (Entity node/video_game/899/Glory and Miserable Survivors DX)
- node (Entity node/video_game/899/Glory and Miserable Survivors DX)
- event (DTO)
- machine-name (string "eca.content_entity.presave")
- user (Entity user/19/HawkX)
HawkX 21:18:47 Asserted condition Flow_0f9whwd for AND from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
HawkX 21:18:47 Execute AND (Activity_045dq0r) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
HawkX 21:18:47 Check action successor Set User UID to HawkX (Activity_0ckrzir) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
- entity (Entity node/video_game/899/Glory and Miserable Survivors DX)
- node (Entity node/video_game/899/Glory and Miserable Survivors DX)
- event (DTO)
- machine-name (string "eca.content_entity.presave")
- user (Entity user/19/HawkX)
HawkX 21:18:47 Asserted condition Flow_0yj37aq for Set User UID to HawkX from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
HawkX 21:18:47 Execute Set User UID to HawkX (Activity_0ckrzir) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
HawkX 21:18:47 Check gateway successor noname (Gateway_1ux9mps) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
- entity (Entity node/video_game/899/Glory and Miserable Survivors DX)
- node (Entity node/video_game/899/Glory and Miserable Survivors DX)
- event (DTO)
- machine-name (string "eca.content_entity.presave")
- user (Entity user/19/HawkX)
HawkX 21:18:47 Unconditional noname (Gateway_1ux9mps) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
HawkX 21:18:47 Execute noname (Gateway_1ux9mps) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
HawkX 21:18:47 Check action successor Set Completed Year (Activity_084wwx4) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
- entity (Entity node/video_game/899/Glory and Miserable Survivors DX)
- node (Entity node/video_game/899/Glory and Miserable Survivors DX)
- event (DTO)
- machine-name (string "eca.content_entity.presave")
- user (Entity user/19/HawkX)
HawkX 21:18:47 Unconditional Set Completed Year (Activity_084wwx4) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
HawkX 21:18:47 Check action successor Increment Site ID value (Activity_0uyx02j) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
- entity (Entity node/video_game/899/Glory and Miserable Survivors DX)
- node (Entity node/video_game/899/Glory and Miserable Survivors DX)
- event (DTO)
- machine-name (string "eca.content_entity.presave")
- user (Entity user/19/HawkX)
HawkX 21:18:47 Unconditional Increment Site ID value (Activity_0uyx02j) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
HawkX 21:18:47 Execute Set Completed Year (Activity_084wwx4) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
HawkX 21:18:47 Execute Increment Site ID value (Activity_0uyx02j) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
HawkX 21:18:47 Check action successor Set Completed ID (Activity_1y1dubb) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
- entity (Entity node/video_game/899/Glory and Miserable Survivors DX)
- node (Entity node/video_game/899/Glory and Miserable Survivors DX)
- event (DTO)
- machine-name (string "eca.content_entity.presave")
- new-completed-id (DTO "709")
- user (Entity user/19/HawkX)
HawkX 21:18:47 Unconditional Set Completed ID (Activity_1y1dubb) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
HawkX 21:18:47 Check action successor Load Site Settings (Activity_00vlr6j) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
- entity (Entity node/video_game/899/Glory and Miserable Survivors DX)
- node (Entity node/video_game/899/Glory and Miserable Survivors DX)
- event (DTO)
- machine-name (string "eca.content_entity.presave")
- new-completed-id (DTO "709")
- user (Entity user/19/HawkX)
HawkX 21:18:47 Unconditional Load Site Settings (Activity_00vlr6j) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
HawkX 21:18:47 Execute Set Completed ID (Activity_1y1dubb) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
HawkX 21:18:47 Execute Load Site Settings (Activity_00vlr6j) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
HawkX 21:18:47 Check action successor Set Completed ID (Activity_1uohpb6) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
- entity (Entity node/video_game/899/Glory and Miserable Survivors DX)
- node (Entity node/video_game/899/Glory and Miserable Survivors DX)
- event (DTO)
- machine-name (string "eca.content_entity.presave")
- new-completed-id (DTO "709")
- site-setting-variable (Entity site_setting_entity/site_completed_id_storage/2/Site Completed ID Storage)
- user (Entity user/19/HawkX)
HawkX 21:18:47 Unconditional Set Completed ID (Activity_1uohpb6) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
HawkX 21:18:47 Execute Set Completed ID (Activity_1uohpb6) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
HawkX 21:19:08 Lazy appliance check for event eca.content_entity.presave regarding ECA ID process_hv3nnbu resulted to apply.
- user (Entity user/19/HawkX)
HawkX 21:19:08 Loading ECA configurations for event eca.content_entity.presave: process_hv3nnbu.
- user (Entity user/19/HawkX)
HawkX 21:19:08 Check On Saving (Event_0v54u0o) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
- user (Entity user/19/HawkX)
HawkX 21:19:08 Start On Saving (Event_0v54u0o) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
HawkX 21:19:08 Check action successor AND (Activity_045dq0r) from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave.
- entity (Entity node/video_game/899/Glory and Miserable Survivors DX)
- node (Entity node/video_game/899/Glory and Miserable Survivors DX)
- event (DTO)
- machine-name (string "eca.content_entity.presave")
- user (Entity user/19/HawkX)
HawkX 21:19:08 Not asserting condition Flow_0f9whwd for AND from ECA Update Year and ID On Save (process_hv3nnbu) for event Drupal\eca_content\Event\ContentEntityPreSave. This actually worked!! I added all 4 of those :
*-min.js
*.min.js
bpmn-modeller.js
modules/contrib/bpmn_io/webpack/bpmn-modeller.js
to the ignore list, and it worked! no more minify errors! (and hopefully the ECA part keeps working) but if it doesnt, i have the logs so I can write back :)
Thanks a lot once more!
I am using "drupal.org/project/minifyjs/"
then i go to this page "/admin/config/development/performance/js"
then use that to minify everything
but this one only has to do "selected files" (which has 40+ pages of 100 files) or "ALL files" which then crashes when it gets to page 35 or so with that one file :)
BUT its not related to ECA so you don't have to keep helping me! hehe... I'll figure it out ;)
Thanks again!!
is there an "ignore" list that minify can have/add? cause it always crashes when it gets to that one file ;)
Thanks for everything always!! :)
Update :
to fix my website, I redid a composer update and then re-did all the minify js manually.
In regards to this, the file named "modules/contrib/bpmn_io/webpack/bpmn-modeller.js" which is used by ECA crashes minify js
---
Then I set 1 game as "completed" and the ECA actually incremented the site value properly and savec/updated everything fine.
(but as I wrote originally), most of the times after a composer update, it always worked... it stops working a few weeks/months after when we play a longer game ;)
BUT at least it 100% worked this time. so if you wish, you can close this issue and if needs be, now that i have a full ECA log, i can reopen with more info if i ever get the issue again :)
It is extremely "random"... AND i only use my games-list website to keep track of games I play with my wife and whenever I complete a new game... We have not completed a game since so I did not test it further yet...
I just checked it out, and i have a much bigger issue (jquery isnt loading at all for some random reason) so everything is super broken...
So I will be fixing that first, then testing out what happens with the logs that i had enabled the last time :)
oh i see. it make sense because the other ECA was being run by cron "daily" and not "when saving node"
I have no idea if i am using "advanced" or not ;)
(i am ULTRA noob) and do not use any actual "programming" in drupal, everything is done on the front end side with modules.
I will have a look at that debugging page and see if i can gather more info
I am the only user ever accessing the database/website so that scenario is not something that could happen in this case :)
Is there any "log" or (new ECA node) that i could add to display any info that could help figure out why its not working?
maybe ECA is trying to access and change the site settings variable using the "default" non authenticated user like it was with my other ECA model we troubleshooted last year? (Just checked) and we ended up adding a "set user uid to *me" at the very start of that one