It seems like the CKE folks are okay with this staying as an <a>
tag vs a <span>
tag, so if it makes sense for them there I'd say it makes sense here. https://github.com/ckeditor/ckeditor5/issues/17063
In that case, this issue can likely be closed, unless anyone has objections?
Thanks for linking the CKE issue @justcaldwell and @sonfd, I added a comment to the thread as well!
morganlyndel β created an issue.
thejimbirch β credited morganlyndel β .
thejimbirch β credited morganlyndel β .
morganlyndel β created an issue.
I tested this patch on an environment that had previously been receiving the "`[aria-*]` attributes do not match their roles" error and confirm that this error went away once the patch was applied.
Steps to test:
- Discover the "`[aria-*]` attributes do not match their roles" error on a site during a Lighthouse scan (recreate the error).
- Download the patch attached to this issue and apply it using composer.
- Clear the cache, then re-run the Lighthouse scan on the offending page.
- Confirm that the error is no longer present on the site.
Thank you!