πŸ‡ΊπŸ‡ΈUnited States @morganlyndel

Account created on 17 April 2019, almost 6 years ago
  • Drupal Front-end Developer at LullabotΒ 
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States morganlyndel

That's what I suspected as well. I submitted reports to Google Maps for each of these issues - hopefully those kinds of requests are something they care to pay attention to and will fix. Thanks for checking into this @itamair !

πŸ‡ΊπŸ‡ΈUnited States morganlyndel

A related issue flagging in Google Maps is that the tags are missing alt attributes. Again, this may not be able to be fixed on the Drupal side, but I wanted to surface just in case.

πŸ‡ΊπŸ‡ΈUnited States morganlyndel

It seems like the CKE folks are okay with this staying as an <a> tag vs a <span> tag, so if it makes sense for them there I'd say it makes sense here. https://github.com/ckeditor/ckeditor5/issues/17063

In that case, this issue can likely be closed, unless anyone has objections?

πŸ‡ΊπŸ‡ΈUnited States morganlyndel

Thanks for linking the CKE issue @justcaldwell and @sonfd, I added a comment to the thread as well!

πŸ‡ΊπŸ‡ΈUnited States morganlyndel

I tested this patch on an environment that had previously been receiving the "`[aria-*]` attributes do not match their roles" error and confirm that this error went away once the patch was applied.

Steps to test:

  • Discover the "`[aria-*]` attributes do not match their roles" error on a site during a Lighthouse scan (recreate the error).
  • Download the patch attached to this issue and apply it using composer.
  • Clear the cache, then re-run the Lighthouse scan on the offending page.
  • Confirm that the error is no longer present on the site.

Thank you!

Production build 0.71.5 2024