Account created on 15 April 2019, over 5 years ago
#

Merge Requests

Recent comments

🇫🇷France Hugo'C

Hi,

Thank you all for the time spend on this subject.

As wotnak suggested I guess that the better outcome would be to ignore this request since this module work as intended.

If It's fine for you I close this issue.

🇫🇷France Hugo'C

Thank you for your replies.

@aridard
I think there was a misunderstanding regarding the target of the issue:
The idea here is to use the module for developing and building assets for production, but not using Vite to serve those assets at all.
In our case, we're using https://www.drupal.org/project/advagg → to handle the hashing.
The only purpose of Vite for us is to build the assets and work in an advanced front-end environment.

@wotnak
- Require manifest.json to be generated for dev mode.
Either way, if this requirement is not in development, it's in production, but this change could potentially cause disruptions that need to be considered.
- Require Vite to be configured to not use hashes in built file names.
We can probably allow both configurations while parsing libraries, but currently, it's mandatory.
- With the module disabled in production (which is the motivation for these changes), it requires manually setting all built chunks/dependencies declared in manifest.json directly in .libraries.yml.
Yes, and that's not an issue if we don't use Vite to serve them, but there is another point here to consider.

I'm considering trying another approach (with quality check, sorry about that) with a config flag as you suggested.

🇫🇷France Hugo'C

Thank you for your nice project and the quick reply.

I'll send you a suggestion, I'd appreciate your feedback and suggestions.

Production build 0.71.5 2024