🇺🇦Ukraine @oleksandr.s

oleksandr.s → created an issue.

oleksandr.s → created an issue.

Thank you for advice, I've created issue fork and created MR.

Also, updated a patch for version 10.3.1

Hi, here is patch for Drupal version 10.3.1. Should work with 10x versions.
Probably also works with 11x versions.

Patch provides client side validation to check file size.

Created MR to add possibility to configure "Maximum upload size" on scorm_field.

oleksandr.s → created an issue.

Add missed ')'

hi @globexplorer

I would not use `$node = $items->getEnitity();` because with such code entity of another can be fetched, not only entity of `node` type.
For example, when Layout Paragraph used then `$items->getEnitity();` will fetch `paragraph` entity.
Please check `$e` variable on sreenshot.

Updated patch. Move code deeper

oleksandr.s → changed the visibility of the branch 3441865-error-attempt-to to hidden.

Hi, I added a fix for this issue by fixing ScormFieldScorFormatter class.

In my case, error happen when use scorm_field with combination of paragraph and used a Layout Paragraphs widget for such paragraph field.
With such combination node object can't be fetched from route, because route is layout_paragraphs.builder.insert

oleksandr.s → created an issue.

Code changes provided in MR, attached to issue, fix the error.
Tested with Drupal 10.3.1 version

I've created MR to fix this issue

oleksandr.s → changed the visibility of the branch 3465236-cant-install-module to hidden.

oleksandr.s → changed the visibility of the branch 1.0.x to active.

oleksandr.s → changed the visibility of the branch 1.0.x to hidden.

oleksandr.s → changed the visibility of the branch 1.0.x to hidden.

oleksandr.s → created an issue.

Hi, tested.
MR4 works for me.

Hi @stmh, thank you for reviewing and testing.

Here is new a patch.

Hi, I have fixed the bug in the MR created here.

Please keep in mind that, while this fixes the bug with undefined $destination variable, you still can't submit the preset creation form due to another bug discussed in [#3314510] 🐛 Entity type 'Drupal\video_transcode\Entity\Preset' is missing 'config_export' definition in its annotation RTBC , also mentioned in #3 🐛 Warning: Undefined variable $destination in PresetFormBase.php Needs review . To fix preset creation bug,
please implement patch from issue [#3314510] 🐛 Entity type 'Drupal\video_transcode\Entity\Preset' is missing 'config_export' definition in its annotation RTBC

oleksandr.s → made their first commit to this issue’s fork.

Hi, here is patch related to this issue.

1. In patch I modified key for '#states' and added 'table' key. As now, drupal builds field storage settings form using table element $element['allowed_values']['table'] . https://git.drupalcode.org/project/drupal/-/blob/10.2.x/core/modules/opt...

2. In patch I modified 'name' selector of list_predefined_options_plugin_id to control states of allowed_values as now, drupal using subform key wrapper. https://git.drupalcode.org/project/drupal/-/blob/10.2.x/core/modules/fie...

oleksandr.s → changed the visibility of the branch list_predefined_options-3436776 to hidden.

When I was developing this patch I was trying to not break current functionality and keep it the same as it was before.
So If before we had:
BEFORE:

// This gets all answers the current user can view.
$query = $answer_storage->getQuery();
$aids = $query->condition('user_id', $this->getOwnerId())
  ->condition('user_module_status', $this->id())
  ->execute();

then, to make result the same we need to change like this:
AFTER:

Unchanged: This gets all answers the current user can view.
$query = $answer_storage->getQuery();
$aids = $query->condition('user_id', $this->getOwnerId())
  ->condition('user_module_status', $this->id())
  ->accessCheck()
  ->execute();

Please, check this example BEFORE and AFTER https://www.drupal.org/node/3201242 → . It shows the similar query examples but with articles content type and how to achieve the same query results after explicitly calling accessCheck().

Here is patch to fix issue.

aleksandr.s → created an issue.

Adding fix for OpignoAnswer as well

Here is patch that fix issue

aleksandr.s → created an issue.

Fix paths in patch.

Here is a patch to fix this issue

aleksandr.s → created an issue.

Create correct patch name.

aleksandr.s → created an issue.