niral098 → created an issue.
Thank you @mauryarahul11 for your work. Will incorporate your changes.
Hi @siddharthjain Thank you for the work so far!
I pulled your changes and tested the feature. It's still not working on my end. Can you please test the following scenario -
1. Create a new node. Put some dummy content in a couple of grids. Save the node. It should work at this point.
2. Re-edit the node by adding a couple of grids with data. Save the node. It breaks.
@lexsoft The module is working fine with #17 (workaround) so far. However, I believe a better solution is required. I am still debugging #16 whenever I get a chance. I will share my work as soon as I get something concrete. Thanks!
Hi @imran1217
@foxy-vikvik had committed some changes on top of @lexsoft - ckeditor-bootstrap-grid-3356334-3.x.0. I pull the codebase from that branch in my local and make it a contrib module, FYI.
+1
#7 works and fixes the warnings mentioned above. Thank you.
Update: When I enable the plugin(toolbar) of ckeditor_bs_grid module, the issue mentioned in #16 seems to be solved.
Hi guys,
Thank you for your hard work. So, I pull the changes of @lexsoft and @foxy-vik from ckeditor-bootstrap-grid-3356334-3.x.0 branch. The problem is whenever I add a new grid column to the body field, the newly added grid column works but the existing grid columns get affected. Please check differences in class names in the following source code of ckeditor5 -
<div class="simple-grid row ck-widget" data-label="Grid" contenteditable="false">
<div class="simple-grid-layout col-xs-12" data-label="Column">
<p>
content
</p>
</div>
<div class="simple-grid-layout col-xs-12" data-label="Column">
<p>
content
</p>
</div>
</div>
<div class="simple-grid row type--default two-col ck-widget" data-label="Grid" data-type="default row two-col" contenteditable="false">
<div class="simple-grid-layout col-xs-12 col-md-6" data-label="Column">
<p>
content
</p>
</div>
<div class="simple-grid-layout col-xs-12 col-md-6" data-label="Column">
<p>
content
</p>
</div>
</div>
When we add new columns, the classes of existing columns get disturbed. I am not sure what's happening at this point and I am still debugging.