πŸ‡§πŸ‡ΎBelarus @alena_stanul

Account created on 26 February 2018, over 6 years ago
#

Merge Requests

Recent comments

πŸ‡§πŸ‡ΎBelarus alena_stanul

I am not agree with patch, because if $options is not empty, then you will artificially reset it to empty array. May be better to use the following code:

function _variable_options($options = array()) {
  $options = ($options !=FALSE) ? $options : [];
  if (!empty($options['language'])) {...

Thanks

πŸ‡§πŸ‡ΎBelarus alena_stanul

Hi,
According to @chetan 11 code changes, the error will not be fixed.
I don't see the difference between сreation of dynamic property in $object->table as it was in the original and when we create array with $object_properties then try to use 'foreach ($object_properties .. ' construction to create property of object EntityQueue class.
I checked the code in the sandbox and the error was not fixed.
Please, check.

πŸ‡§πŸ‡ΎBelarus alena_stanul

These types of warnings are considered in PHP 8.1 warnings. Passing null to parameter of type string is deprecated πŸ› PHP 8.1 warnings. Passing null to parameter of type string is deprecated Needs review issue.

πŸ‡§πŸ‡ΎBelarus alena_stanul

It seems that the ds-results_null_fix-2468303-4.patch is incorrect. An addition of code elseif ($results) {is meaningless before foreach ($results as $id => $result) {.

πŸ‡§πŸ‡ΎBelarus alena_stanul

The ctools.php-8-compatibility.patch is not applied. I suggest to use the following patch.

Production build 0.69.0 2024