πŸ‡ΊπŸ‡¦Ukraine @rowen92

Account created on 31 October 2017, about 7 years ago
#

Recent comments

πŸ‡ΊπŸ‡¦Ukraine rowen92

Regarding passing $already_cloned array to EntityCloneEvent

I think it's possible without breaking any functionality.

See an example with an optional parameter.
EntityCloneEvent::__construct(...)

public function __construct(EntityInterface $entity, EntityInterface $cloned_entity, array $properties = [], array $already_cloned = []) {

Adding getter and setter methods would be great as well.

πŸ‡ΊπŸ‡¦Ukraine rowen92

And you guys are breaking current implementation of users which already use existing implementation of event dispatching.

I think you have to implement another type of event if you really want to have it dispatched for references.

πŸ‡ΊπŸ‡¦Ukraine rowen92

I think passing $already_cloned variable would be really useful for modifying.

What do you think?

At least for cases when some extra referenced entities might be cloned.
In the current implementation we aren't able to know if a referenced entity was already cloned or not.

πŸ‡ΊπŸ‡¦Ukraine rowen92

Hello, a patch is added.

πŸ‡ΊπŸ‡¦Ukraine rowen92

Great work guys, seems to be working well, any thoughts when it will be merged?

πŸ‡ΊπŸ‡¦Ukraine rowen92

Hello, is that possible to have these changes in the dev version at least?

It would be great

Production build 0.71.5 2024