Account created on 11 June 2017, over 7 years ago
#

Merge Requests

Recent comments

🇵🇹Portugal kallado

Merged and available on version 1.0.3

🇵🇹Portugal kallado

@achap I'm also adding this here https://www.drupal.org/project/auto_node_translate/issues/3483484 Add Google V3 glossary support Active leave a comment there so I can credit you when I fix the issue.

🇵🇹Portugal kallado

@achap Thanks a lot! Kind of a busy week on my end but i'll take a look as soon as possible.

🇵🇹Portugal kallado

Thanks you! I would actually like to refractor this module to work in a way we could use plugins for translation providers, kind of in the way the Translation Management Tool does. But this would require a complete new version. I'll take a look at your implementation that will help a lot.

🇵🇹Portugal kallado

@dehacker Not a lot of spare time at the moment but we will take a look when we can.

🇵🇹Portugal kallado

@simonbaese Thanks I'm available to help if you need to just a lot of work at the moment to dive into this.

🇵🇹Portugal kallado

To add the variables to the SymfonyMailerQueueItem I think it shoul be somewere in QueueSendingEmailAdjuster
probably here:

if (!$email->isInQueue()) {
      $queue = $this->queueFactory->get(SymfonyMailerQueueWorker::QUEUE_NAME, TRUE);
      $item = new SymfonyMailerQueueItem(
        $email->getType(),
        $email->getSubType(),
        $email->getParams(),
        $this->configuration,
      );
      $queue->createItem($item);

Where we could use the Email method getVariables() to retrieve the values

🇵🇹Portugal kallado

Feals like in symfony_mailer/src/Processor/EmailBuilderManager.php
/**
* {@inheritdoc}
*/
public function createInstanceFromMessage(array $message) {
$this->buildCache();
$suggestions = [
"$message[module].$message[key]",
$message['module'],
];

foreach ($suggestions as $plugin_id) {
if ($this->hasDefinition($plugin_id)) {
return $this->createInstance($plugin_id);
}
if ($override_id = $this->overrideMapping[$plugin_id] ?? NULL) {
return $this->createInstance($override_id);
}
}
}

There is nothing being returned and that is what causes the issue. It might not be a issue with the module but in the way you're handaling the email.

🇵🇹Portugal kallado

@prem suthar your solution
if (!$builder) {
$email = $builder->fromArray($this->emailFactory, $message);
}

I haven't teste this but im pretty sure that if that condition is fulfiled (the $builder is NULL) you will have the same exact error.
"Call to a member function fromArray() on null"
This will also create another error in
if ($send) {
$message['result'] = $email->send();
}
Because the email won't be defined
I think we have to digg a littlle bit deeper and understant why the $buildr is NULL in the first place

🇵🇹Portugal kallado

kallado changed the visibility of the branch 3464034-content-kanban-doesnt to active.

🇵🇹Portugal kallado

kallado changed the visibility of the branch 3464034-content-kanban-doesnt to hidden.

🇵🇹Portugal kallado

@tylvis these are the available fields in the api https://developers.facebook.com/docs/instagram-basic-display-api/reference/media#fields. We are retrieving the "media_url" in it's original format so this is what we ge from the api. We can't do anything else.

🇵🇹Portugal kallado

@darrenoh @perrygeorget New plugin for Google V3 available TMGMT Translator GoogleV3Translate . It would be nice if you added a section of related modules or some info about this in the description o this module. We added a link to this one in the Related Modules section it would male it easier for users to find V2 and V3 versions without having to browse the issues.

🇵🇹Portugal kallado

@darrenoh We are the creators of Auto Node Translate and we already developed the TMGMT Translator LibreTranslate . Sinece we support Google V3 we will be starting on a new Google V3 translator implementation for TMGMT. Since the configuration and translation process are quite different we think the best aproach is a new module. I'll keep you posted on the evoulution of the module if you want to.

🇵🇹Portugal kallado

@aman_lnwebworks sorry it took so long but have been on tigh schedule. Merged and will be available on the next release

🇵🇹Portugal kallado

@rpayanm thanks merged and will be available on the next release

🇵🇹Portugal kallado

@johan.gant It seams the issue also happens in 2.1.9 version

🇵🇹Portugal kallado

Thanks I'm kind of struggling with time now but I'll review it as soon as possible.

🇵🇹Portugal kallado

Sorry we've been very busy will change the status and review wenever possible.

🇵🇹Portugal kallado

To be honest that composer.json doesn't even need to exist it was used for a local repository and shouldn't have been commited in the first place.

🇵🇹Portugal kallado

You're right theres a bug in the composer.json i'll fix it a soon as possible

🇵🇹Portugal kallado

It's possible but to be honest this is a very simple consent poput it pretty much just hides the html with css. It would have to integrate with the recaptcha module and the validation would have to be done programatically.
I'm don't have a lot of spare time right now but i'll take a look when I have or if i found there's more people interested in this.

🇵🇹Portugal kallado

Not really but if you are interessed in helping out you can take a look at how the amazon API was implementede here
https://www.drupal.org/project/auto_node_translate/issues/3322954 🌱 Addition of Amazon Translate to auto_node_translate Fixed
We are kind of busy right now and still have some opened issues (bugs) to fix but we can take a look wenever we have some spare minutes.

🇵🇹Portugal kallado

Ok patch cmmited to dev.
@AlfTheCat I'm not sure when a new release will be availabe because to be honest this isn't a bug from module.
The module is suposed to show a consent popup, it does.
You choose to use a browser that blocks consent popups, it does.
Everything works as expected.
Anyway the patch works.

🇵🇹Portugal kallado

Patch created check if it works and let me know.

🇵🇹Portugal kallado

The translate paragraph wasn't being loaded can you test this patch?
However I always recomend translating from english since is usually the most complete dicionary for the translators.

🇵🇹Portugal kallado

This should be solved in version 1.0.4
https://www.drupal.org/project/consent_popup/issues/3385450 🐛 Doesn't work for anonymous users Fixed

🇵🇹Portugal kallado

@piousbox never mind it works anyway. I'll merge and create a new version asap.

🇵🇹Portugal kallado

@piousbox I think you are removing the validation for the url to solve this issue https://www.drupal.org/project/consent_popup/issues/3385449 Cannot redirect to a url outside my domain Fixed
but that alone won't work since in build we are expecting the url to be relative so an external url won't work anyway. Maybe we can fix both problems in this issue and merge both. I might have some time to look at it this week (maybe even today)

🇵🇹Portugal kallado

@piousbox Not sure when I can get to this really busy at the moment. For now if you want to a suggestion you could create a custom route for the popup to redirect to and redirect that page to where you want with some code.

🇵🇹Portugal kallado

I can't reproduce the issue. I have the module working in some sites and it works for anonymous users. Check if you have any restrictions on the block for roles or any other permissions.

🇵🇹Portugal kallado

@DudeWeb just checked the code and error is here
'@code' => $error->error->code,
seams like $error is a string so maybe there's some issue with what the API returns in case of error but for sure there's an problem in the attempt to translate.

🇵🇹Portugal kallado

@DudeWeb sorry been on vacations the Amazon api was not created by us, it was a contribution from another member @Ctrlfreq https://www.drupal.org/project/auto_node_translate/issues/3322954 🌱 Addition of Amazon Translate to auto_node_translate Fixed
I haven't tested it and i don't really have a way of doing it since i don't have an amazon acount i can use but it looks like an error is coming from the api.
Not sure how i can help you but I would check if the 'TargetLanguageCode' option expected in amazon might be diferent from the code given from Drupal

Production build 0.71.5 2024