I faced the same Issue and came to the same conclusion as the Issue description.
Patch still applies, the extending the query looks good. Solved the problem for me.
I also needed this for a project, and created a basic version based on the D7 patch. Still needs some work, but might be worth a quick review about the approach.
maacl → made their first commit to this issue’s fork.
This can be closed as duplicate of ✨ Support Server-Side GTM RTBC .
The Issue I referenced 3 years ago has been closed as duplicate of #3311595: Html::transformRootRelativeUrlsToAbsolute() replaces "\r\n" with " \n" → , which has been fixed in 10.1. Does this fix the Issue here?
Thanks for the bug report! It would be great to have a test for this!
let's see if we can add a test for this.Honestly I'm not sure how to test this. Did you have a specific approach you were thinking of?
I think it should be possible to install the module in a test, and then it should only pass if the media and file module are enabled also? And currently they won't be enabled because of the missing dependency.
Thanks for the report and the patch, let's see if we can add a test for this.
Sorry for the late reply! You have to keep the default settings from Drupal:
A new make_unused_managed_files_temporary setting exists in file.settings which is set to false by default, for both existing and new sites.
Otherwise you may be hit by the unexpected deletion of files. This modules takes over the responsibility to mark files as temporary when they are no longer used by a media entity.
Created a patch, I guess the transform attribute should only apply to the background of the image.