Removed error handling which was based on a different return value from another api call.
looks good
found 2 other issues w/ d10, request stack class & pusher trigger call w/ wrong parameters.
patch attached
the composer.json should now also require ^4.1.8, other than that looks good #nw
Found a bug where the selected range would be messed up due to the removal of a node within the range.
For example:
<body>[<p></p><span>text</span>]</body>
range (container:offset): body:0 body:2
trimElements(firstNode); will then remove <p></p>
if this happens after the range sets the end point the end node:offset will stay body:2 although, we only have 1 element now.
<body>[<span>text</span>]</body>
range (container:offset): body:0 body:2 (should be body:1)
Fixed by moving trimElements(firstNode); before ranges[0].setEndAfter(lastNode) so that it will have the correct amount of nodes to set the proper offset value.
I applied the existing patch & added to commit to the fork MR
#approved #merged & created release https://www.drupal.org/project/amazon_paapi/releases/1.1.5 →
yes, rest.resource.rest_menu_item can be just default config #nr
checking
Enabled config_rewrite & removed rest_menu_items.config from install hook.
rest.resource.rest_menu_item cant be imported via config_rewrite as it is part of the rest_menu_items_test module, which is not enabled/required.
#nr
The responsive_image module has a wrapper function _responsive_image_image_style_url()
which triggers transformRelative() after generateAbsoluteString(), thus reverting the conversion to an absolute url.
Fixed by adding a check of the lupus_decoupled setting `absolute_file_urls` in transformRelative()
#nr