🇳🇱Netherlands @arjenk

arjenk → changed the visibility of the branch 3509562-azure-b2c-v2-check to active.

arjenk → changed the visibility of the branch 3509562-azure-b2c-v2-check to hidden.

arjenk → created an issue.

arjenk → created an issue.

The last patch did not apply due to incorrect directory references, so i made an updated one. Also updated some styleguide issues as phpstan was complaining.

arjenk → made their first commit to this issue’s fork.

This is starting to look very good. Just a couple of small remarks;

+  public function __construct(CountryFieldManager $countryFieldManager) {
+    $this->countryFieldManager = $countryFieldManager;
+  }

You will need to call the parent::__construct() here, otherwise the non overridden functions in FormatterBase are missing services. The current implementation breaks the settings of the field.

+  public function __construct(CountryFieldManager $countryFieldManager) {
+    $this->countryFieldManager = $countryFieldManager;
+  }

That means this will also needs more parameters.

+  /**
+   * {@inheritdoc}
+   */

Bonus points for replacing this with the correct parameter definitions.

This now works for me, would be great if more people could use their testset to test the migration process.