🇺🇸United States @dabblela

I'm not positive this is the same issue because I'm not running 2.x, but my page manager metags went missing updating to 4.0-rc3 because of this: https://www.drupal.org/project/page_manager/issues/3362561 🐛 Path has unnecessary query appended. Fixed

if ($variant = $route_match->getParameter('page_manager_page_variant')) {
    return $variant;
  }

The `page_manager_page_variant` variant no longer exists.

dabblela → created an issue.

dabblela → changed the visibility of the branch 3.x to hidden.

dabblela → created an issue.

dabblela → created an issue.

Test failures appear to be unrelated to this MR

Opened a MR for this issue

dabblela → created an issue.

dabblela → created an issue.

Updated the comment on the translation controller. Thanks for the review @catch

dabblela → made their first commit to this issue’s fork.

Thanks @quietone and @Spokje for the reviews. I've updated the patch to address the feedback.

Agreed with @fathima.asmat, this definitely needs a way to update the default revision of a translation that has never been published. I think it can be done with this code, but I'm a little wary of potentially looping through every revision of a node so I took a different approach.

I was able to fix the issue here by:
1) applying the patch from 🐛 New translations for moderated nodes are not created in the initial workflow state Needs work
2) setting the default moderation state to "Default moderation state" and
3) creating a new state called "Pre-published" with "Default revision" enabled

This approach has worked better in testing with modules that use `hasTranslationChanges` (eg, paragraphs), I think because the default revision field is set earlier in the entity save process.

@catch Thanks for the review. I think the only question about loading the entity is whether to load the translation from the default revision, or to load latest translation affected revision for each language. As far as I can tell, the way the patch is currently written saves data to the revision table in the same way as creating translations without the patch.

dabblela → created an issue.

It looks like this is the same issue as 🐛 Creating a new translation may delete translations with drafts Fixed . That issue also has a patch with tests, but a different fix. I'm not really sure what the best approach is, I think the patch there is a little closer to how translation currently works.

I don't believe 🐛 Installing a module causes translations to be overwritten Fixed is related, that looks more like interface translation than content translation.

dabblela → created an issue.

Fixing incompatible method declaration in TableWidget in #187

Attaching a patch with the tests and an attempted fix.

@tim.plunkett The bug has different effects depending on if a new translation is published vs if the new translation is a draft so I tried to cover both cases with a test.

@joseph.olstad I took a look but I don't think these two are related. As far as I can tell this is specifically from the way the "add translation" form prepares the node object for saving.

Tests for the 2 cases.