+1 For this feature, been looking through the docs of storybook and webpack, but I cannot make out, how to tell them to hot-reload stories, when the CSS files change.
I tried to add the scss compilation to storybooks webpack-config, and got the compilation working, but it still did not trigger the reloading of the stories when needed.
If I remember right, hot-reloading was possible in the past with the drupal-storybook-addon - but I'm not 100% sure.
We either need to manually trigger the storybook reload - or find a way to tell it, that it should watch the files that are picked up as sdc-libraries automatically - and reload on changes of them.
Sadly without hot-reloading frontend-development with storybook is more painful than it needs to be :D
Tested the Patch from #2 and can confirm it works :)
fisherman90 → created an issue.
fisherman90 → created an issue.
I can confirm, that now MR !162 solves it for me, szenario:
* Page manager page instead of views-page
* Layout builder layout / variant
* Facets and facet-summary rendered
Both - the facets and the summary - are updating correctly for me.
I came here, because I'm using seven in a project, too. Was wondering really, why the code tests against certain admin themes?
For me MR12 sounds like the solution, if nobody can name a reason to limit the functionality to those themes.
Joachim Namyslo → credited fisherman90 → .
FYI for anyone reaching this issue after Upgrading to 10.2:
The patch from #42 works great on Group 3.x and fixes the access in the media library Modal when creating a new Group-Node.
I would mark it as RTBC for 3.x, but the Issue seems to be for multiple Group-Versions (with 1.x tagged) and I have not tested the 1.x patch.
But since @jilashomb has confirmed, that 1.x seems to be working with the patch from #41, I will mark it as RTBC anyway.
If this gives trouble, we could split the issue up for the different Group-Versions.
gnuschichten → credited fisherman90 → .
sanduhrs → credited fisherman90 → .
sanduhrs → credited fisherman90 → .
sanduhrs → credited fisherman90 → .
sanduhrs → credited fisherman90 → .
Looks good :)
Looks good :)
gnuschichten → credited fisherman90 → .
fisherman90 → created an issue.
fisherman90 → created an issue.
Changed title and summary of issue to reflect the requested feature better and bumped version up to 8.x.
+1 for this issue, would like to test it for you @idebr, I guess you already did the conceptual heavy lifting, but the branch-patch does not apply anymore.
If you would update the branch to be applicable, I would be more than happy to test the feature for you and give feedback :)
Added MR, happy testing :)
fisherman90 → created an issue.
@bogdanstamate06 I've tried removing the total count number from the "Count down message" (is that what you meant?).
Also in case I understood it differently, I reduced the "Max length" Number for an already existing field, which also seems to work with spaces / lines.
Are you sure this has something to do with this issue? Or is it maybe another Problem you are running into?
Sounds like maybe your text formats need to have a look at.
At least for now I cannot reproduce that the spaces / line breaks get broken by the change.
If this is still an issue for you and does not come from text formats or so: Can you post a reproductible scenario for me, so I can try to get the error on my setup, too?
If you want, please have a look at my approach in https://git.drupalcode.org/project/maxlength/-/merge_requests/25 .
I'm repsecting the "Hard limit" option as well as syncing the textfield with the contents of the editor.
This way, maxlength counting works again.
I'm sure there's better approaches to solving this, but I didn't find any better.
fisherman90 → made their first commit to this issue’s fork.
Hey bogdanstamate06,
This is a experimental sandbox module, where we tried to do an integration, but currently the approach does not seem to be working. Module sandboxes are not meant to be used yet.
Sorry for the inconvenience. But maybe https://www.drupal.org/project/maxlength → is a solution for you, in https://www.drupal.org/project/maxlength/issues/3267413 🐛 Countdown not working for ckeditor5 Fixed people are trying to make it work with CKEditor5.
Thanks a lot for giving such qualitative and constructive feedback :D
Learned something new through it, very appreciated.
Also thanks to anyone else involved - pleasure working with you :)
Since the last patch did not really clear the errors for me, I rebuilt it with a small addition.
Hope this helps. Feedback welcome.