πŸ‡¨πŸ‡­Switzerland @amermod

Account created on 19 October 2015, about 9 years ago
#

Recent comments

πŸ‡¨πŸ‡­Switzerland amermod

Tested patch #6 on Drupal 10.2.6 and color_field v. 3.0.0

Works good !

πŸ‡¨πŸ‡­Switzerland amermod

Hi,

I just made a patch for the edit link only, because the link in the entity annotation is fixed in this issue πŸ› Some mandatory parameters are missing ("token_custom") Needs review .

So now both patch can be applied.

But a full rework of the paths should be made... Those fix are just small patches, not good enough IMO.

πŸ‡¨πŸ‡­Switzerland amermod

amermod β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡­Switzerland amermod

We are still talking about revision checks while it should be the role of the EntityAccessControlHandler to do the revision access check.

And it actually does that already, so why is there still a revision access check in the jsonAPI module ? Because the EntityAccessControlHandler can not be trusted for revisions, as said in #3, four years ago ?

I just attached a patch that removes simply the revisions check, to see what will fail.

πŸ‡¨πŸ‡­Switzerland amermod

I made a patch for the solution proposed in #27.
I think it's a good solution for BC and is easy to implement for everyone who needs it.

Then we can add a deprecation notice and switch for the Symfony access check in a future Drupal release maybe ?

Production build 0.71.5 2024