πŸ‡³πŸ‡±Netherlands @Zevior

Account created on 13 October 2015, over 8 years ago
#

Recent comments

πŸ‡³πŸ‡±Netherlands Zevior

@rszrama shouldn't the promotion code check the target product's availability using AvailabilityManager? That sounds like a way to give modules an opportunity to deny the action.

πŸ‡³πŸ‡±Netherlands Zevior

Was this tested? AFAICS the $this->t won't work inside the static function.

πŸ‡³πŸ‡±Netherlands Zevior

Hard to test, but did it anyway putting

        "-1": {
            "type": "vcs",
            "url": "https://git.drupalcode.org/issue/email_validator-3391284.git"
        },

in composer's repositories and requiring "drupal/email_validator": "dev-3391284-drupal-10-installation-issue",
Can confirm MR fixes the issue.

πŸ‡³πŸ‡±Netherlands Zevior

I'm having the same issue as well, it seems like the same problem as https://www.drupal.org/node/3227032 β†’
I'm going to be using that patch (rerolled) for now.
Question for maintainer: what prompted this revert: https://git.drupalcode.org/project/domain_path/-/commit/8084c7292d8326f2...

The weird thing is that i can't reproduce this on a clean install, only in my (somewhat large) project. I couldn't quickly find what causes this difference, but my gut says it has something to do with other code calling domainNegotiator->getActiveDomain early, like in kernel subscribers. I don't have time right now to investigate that further, so i'll continue using the fix from issue 3227032 for now

Production build 0.69.0 2024